POV-Ray : Newsgroups : povray.beta-test : POV-Ray v3.8.0-alpha.10011104 Server Time
17 Sep 2021 21:57:20 EDT (-0400)
  POV-Ray v3.8.0-alpha.10011104 (Message 25 to 34 of 34)  
<<< Previous 10 Messages Goto Initial 10 Messages
From: William F Pokorny
Subject: Re: POV-Ray v3.8.0-alpha.10011104
Date: 14 Jan 2019 12:16:43
Message: <5c3cc3fb$1@news.povray.org>
On 1/14/19 11:39 AM, clipka wrote:
> Am 14.01.2019 um 15:07 schrieb William F Pokorny:
> 
>> File 'Sig00.pov' line 2: Parse Warning: Float value promoted to full 
>> color vector where both filter and transmit >0.0.
>> File 'Sig00.pov' line 1: Parse Error: End of file reached but #end 
>> expected.
>> Fatal error in parser: Cannot parse input.
>> Render failed
> 
> Traced this down to a bug in the scanner that kicks in whenever two 
> consecutive returns from a macro or include file jump back to the same 
> binary offset in (formally) different input streams
> 
> One such scenario is the return from a macro that has called itself 
> recursively and hasn't called other macros since.

Cool. Glad you found it.

Bill P.


Post a reply to this message

From: William F Pokorny
Subject: Re: POV-Ray v3.8.0-alpha.10011104
Date: 14 Jan 2019 12:23:12
Message: <5c3cc580$1@news.povray.org>
On 1/13/19 5:07 PM, clipka wrote:
> Am 13.01.2019 um 23:04 schrieb clipka:
>> Another known issue:
...
> 
> Users building their own binaries (most notably Unix users) may also use 
> `source/core/shape/truetype.cpp` from the latest master, which should 
> fix the issue:
> 
>
https://raw.githubusercontent.com/POV-Ray/povray/master/source/core/shape/truetype.cpp

> 

Stuff still running. I've turned up several more of the macro/include 
return type.

One of our standard shipped scene files fails due a form feed character 
'0c' very near the end the end of the file. That scene is:

.../distribution/scenes/objects/superel2.pov

and here I think we just need to update that scene file.

Bill P.


Post a reply to this message

From: clipka
Subject: Re: POV-Ray v3.8.0-alpha.10011104
Date: 14 Jan 2019 13:41:32
Message: <5c3cd7dc$1@news.povray.org>
Am 14.01.2019 um 18:15 schrieb William F Pokorny:

> Suppose my question was too whether we should consider the 3.7/3.8 
> behavior broken - you seem to be saying it was.

Let's put it this way: Going by the reference docs on numeric 
expressions - specifically FLOAT_LITERAL - the v3.7 behaviour would have 
to be considered broken, unless interpreting the syntax in a 
self-inconsistent manner.

The key question is under what circumstances a sequence of characters 
that matches the production rules of FLOAT_LITERAL, followed by some 
other character that does not fit in, constitutes a broken 
FLOAT_LITERAL, as opposed to a valid FLOAT_LITERAL token immediately 
followed by the next token.

The v3.6 behaviour can easily be interpreted as consistently treating 
such cases as valid, but erroneously implementing MANTISSA as:

     MANTISSA:
       DIGIT... [DECIMAL_POINT | [DIGIT2...] |
       DECIMAL_POINT DIGIT2...
     DIGIT2:
       DIGIT | DECIMAL_POINT

The v3.7 behaviour must be interpreted as treating such cases as broken 
if the non-matching character is a dot, but valid if it is any other 
character. That's a pretty arbitrary distinction.

The (new) v3.8 behaviour consistently treats all such cases as valid 
again, while implementing MANTISSA as documented.


> Folks can again cause parsing to separate values by using extra decimal 
> points in numeric strings. Has me wondering what might happen with typos 
> like 1..2 (not tried it).

That would have to be `1.` followed by `.2`.

> Or where we specify lists of values separated 
> by commas or not. Can the latter get scrambled in ways that are confusing?

Dots don't constitute valid infix or postfix operators in numeric 
expressions, so there's no ambiguity there.


Post a reply to this message

From: William F Pokorny
Subject: Re: POV-Ray v3.8.0-alpha.10011104
Date: 14 Jan 2019 15:29:29
Message: <5c3cf129$1@news.povray.org>
On 1/14/19 1:41 PM, clipka wrote:
> Am 14.01.2019 um 18:15 schrieb William F Pokorny:
> 
>> Suppose my question was too whether we should consider the 3.7/3.8 
>> behavior broken - you seem to be saying it was.
> 
> Let's put it this way: Going by the reference docs on numeric 
> expressions - specifically FLOAT_LITERAL - the v3.7 behaviour would have 
> to be considered broken, unless interpreting the syntax in a 
> self-inconsistent manner.
> 
> The key question is under what circumstances a sequence of characters 
> that matches the production rules of FLOAT_LITERAL, followed by some 
> other character that does not fit in, constitutes a broken 
> FLOAT_LITERAL, as opposed to a valid FLOAT_LITERAL token immediately 
> followed by the next token.
> 
> The v3.6 behaviour can easily be interpreted as consistently treating 
> such cases as valid, but erroneously implementing MANTISSA as:
> 
>      MANTISSA:
>        DIGIT... [DECIMAL_POINT | [DIGIT2...] |
>        DECIMAL_POINT DIGIT2...
>      DIGIT2:
>        DIGIT | DECIMAL_POINT
> 
> The v3.7 behaviour must be interpreted as treating such cases as broken 
> if the non-matching character is a dot, but valid if it is any other 
> character. That's a pretty arbitrary distinction.
> 
> The (new) v3.8 behaviour consistently treats all such cases as valid 
> again, while implementing MANTISSA as documented.
> 
> 
>> Folks can again cause parsing to separate values by using extra 
>> decimal points in numeric strings. Has me wondering what might happen 
>> with typos like 1..2 (not tried it).
> 
> That would have to be `1.` followed by `.2`.
> 
>> Or where we specify lists of values separated by commas or not. Can 
>> the latter get scrambled in ways that are confusing?
> 
> Dots don't constitute valid infix or postfix operators in numeric 
> expressions, so there's no ambiguity there.

Thanks for the detail. I've been playing with variations for the last 
hour or so and created some new parser test cases in my collection to 
track this change. While 1..2 gets treated as two numbers .1..2 and the 
like do not - so even the exposure to period over comma typos is small.

Not picked up anything new and have switched over to your latest code - 
it fixed all the recursive return fails I had. Should finish up tomorrow 
sometime and will post again only if something new turns up.

For the record I'm only checking the parser with my tests. I'm not doing 
image to image compares. Image compares will happen over time after I 
rebase my branches onto the current master head and continue other 
efforts.

Bill P.


Post a reply to this message

From: clipka
Subject: Re: POV-Ray v3.8.0-alpha.10011104
Date: 14 Jan 2019 15:47:39
Message: <5c3cf56b$1@news.povray.org>
Am 14.01.2019 um 21:29 schrieb William F Pokorny:

> For the record I'm only checking the parser with my tests. I'm not doing 
> image to image compares. Image compares will happen over time after I 
> rebase my branches onto the current master head and continue other efforts.

I think that's perfectly fine; I don't expect any parser issues to be 
subtle enough to make it to the rendering stage - with the exception of 
string and text handling, specifically non-ASCII stuff.


Post a reply to this message

From: clipka
Subject: Re: POV-Ray v3.8.0-alpha.10011104
Date: 14 Jan 2019 15:54:21
Message: <5c3cf6fd$1@news.povray.org>
Am 14.01.2019 um 18:23 schrieb William F Pokorny:

> One of our standard shipped scene files fails due a form feed character 
> '0c' very near the end the end of the file. That scene is:
> 
> ..../distribution/scenes/objects/superel2.pov
> 
> and here I think we just need to update that scene file.

Page breaks used to be common in ASCII files a while ago; I feel somehow 
inclined to just allow them as whitespace.

The only thing that's holding me back is that I'm not exactly sure what 
effect they should have on column and line counting.


Post a reply to this message

From: William F Pokorny
Subject: Re: POV-Ray v3.8.0-alpha.10011104
Date: 15 Jan 2019 06:03:57
Message: <5c3dbe1d$1@news.povray.org>
On 1/14/19 3:54 PM, clipka wrote:
> Am 14.01.2019 um 18:23 schrieb William F Pokorny:
> 
>> One of our standard shipped scene files fails due a form feed 
>> character '0c' very near the end the end of the file. That scene is:
>>
>> ..../distribution/scenes/objects/superel2.pov
>>
>> and here I think we just need to update that scene file.
> 
> Page breaks used to be common in ASCII files a while ago; I feel somehow 
> inclined to just allow them as whitespace.
> 
> The only thing that's holding me back is that I'm not exactly sure what 
> effect they should have on column and line counting.

Yeah, suppose they could be as whitespace. Then we'd want to provide the 
same treatment for some other printer(system bell?) oriented encodings 
too if you go that route. Vertical-tab comes to mind & expect there are 
a few more.

Even in the old days it was printer dependent in terms of real world 
space(1) so not sure treating those special characters as something 
other than a single white space makes sense. I say this, though, not 
knowing what the POV-Ray windows editor does which such characters?

As for having these kind of characters in sample scene files we ship, 
suppose I'd argue they shouldn't exist. In my editor/font I get some odd 
fill-in character for it. I'm not sure what others might or might not see.

Bill P.

(1) - Do I admit my earliest college programming classes used teletype 
computer terminals... Ah, the noise. :-)


Post a reply to this message

From: Cousin Ricky
Subject: Re: POV-Ray v3.8.0-alpha.10011104
Date: 15 Jan 2019 08:25:00
Message: <web.5c3dde4a2cb80e7893ab27150@news.povray.org>
William F Pokorny <ano### [at] anonymousorg> wrote:
> On 1/14/19 3:54 PM, clipka wrote:
> > Am 14.01.2019 um 18:23 schrieb William F Pokorny:
> >
> >> One of our standard shipped scene files fails due a form feed
> >> character '0c' very near the end the end of the file. That scene is:
> >>
> >> ..../distribution/scenes/objects/superel2.pov
> >>
> >> and here I think we just need to update that scene file.
> >
> > Page breaks used to be common in ASCII files a while ago; I feel somehow
> > inclined to just allow them as whitespace.
> >
> > The only thing that's holding me back is that I'm not exactly sure what
> > effect they should have on column and line counting.
>
> Yeah, suppose they could be as whitespace. Then we'd want to provide the
> same treatment for some other printer(system bell?) oriented encodings
> too if you go that route. Vertical-tab comes to mind & expect there are
> a few more.
>
> Even in the old days it was printer dependent in terms of real world
> space(1) so not sure treating those special characters as something
> other than a single white space makes sense. I say this, though, not
> knowing what the POV-Ray windows editor does which such characters?

At the very least, it seems logical to increment the line count.  I don't think
it would be necessary--or, at this late date, prudent--to assume a certain
number of lines per page.

[...]

> (1) - Do I admit my earliest college programming classes used teletype
> computer terminals... Ah, the noise. :-)

You make me feel young, now.  I had VT-100s in college.

Although at my co-op job, I actually had to deal with punched cards and IBM's
JCL.


Post a reply to this message

From: William F Pokorny
Subject: Re: POV-Ray v3.8.0-alpha.10011104
Date: 16 Jan 2019 09:33:58
Message: <5c3f40d6$1@news.povray.org>
On 1/15/19 8:21 AM, Cousin Ricky wrote:
> William F Pokorny <ano### [at] anonymousorg> wrote:
> 
> At the very least, it seems logical to increment the line count.  I don't think
> it would be necessary--or, at this late date, prudent--to assume a certain
> number of lines per page.

Not sure. The common unix line counting command shows the line count 
(and character) as if the form feed and vertical tab characters are just 
spaces.

Editors seem to be different. GVim (1) is showing ^L and ^K stand in 
sequences and then columns after in each line as a range, 10-11 say, 
instead of a fixed 10. Gedit shows single undefined unicode characters 
breaking the mono-space width. Others tried create a mono-space stand at 
least indicating some odd character is present and the visual 
representation stays aligned. Expect some of the editor behavior is 
driven by the font in use. Though in trying a few different fonts with 
gvim, fixed and not, it is always showing the ^L or ^K sequence and some 
visual miss-alignment.

(1) - all vi based editors I expect

> 
> [...]
> 
>> (1) - Do I admit my earliest college programming classes used teletype
>> computer terminals... Ah, the noise. :-)
> 
> You make me feel young, now.  I had VT-100s in college.
> 
> Although at my co-op job, I actually had to deal with punched cards and IBM's
> JCL.
> 
> 
JCL :-). How do we want the file xyz to physically exist on the drive... 
I worked with it a fair bit early in my work career.


Post a reply to this message

From: Alain
Subject: Re: POV-Ray v3.8.0-alpha.10011104
Date: 16 Jan 2019 15:06:14
Message: <5c3f8eb6$1@news.povray.org>
Le 19-01-15 à 06:03, William F Pokorny a écrit :
> On 1/14/19 3:54 PM, clipka wrote:
>> Am 14.01.2019 um 18:23 schrieb William F Pokorny:
>>
>>> One of our standard shipped scene files fails due a form feed 
>>> character '0c' very near the end the end of the file. That scene is:
>>>
>>> ..../distribution/scenes/objects/superel2.pov
>>>
>>> and here I think we just need to update that scene file.
>>
>> Page breaks used to be common in ASCII files a while ago; I feel 
>> somehow inclined to just allow them as whitespace.
>>
>> The only thing that's holding me back is that I'm not exactly sure 
>> what effect they should have on column and line counting.
> 
> Yeah, suppose they could be as whitespace. Then we'd want to provide the 
> same treatment for some other printer(system bell?) oriented encodings 
> too if you go that route. Vertical-tab comes to mind & expect there are 
> a few more.
> 
> Even in the old days it was printer dependent in terms of real world 
> space(1) so not sure treating those special characters as something 
> other than a single white space makes sense. I say this, though, not 
> knowing what the POV-Ray windows editor does which such characters?
> 
> As for having these kind of characters in sample scene files we ship, 
> suppose I'd argue they shouldn't exist. In my editor/font I get some odd 
> fill-in character for it. I'm not sure what others might or might not see.
> 
> Bill P.
> 
> (1) - Do I admit my earliest college programming classes used teletype 
> computer terminals... Ah, the noise. :-)

Treating form feed as just line feed or new line should be correct.


Post a reply to this message

<<< Previous 10 Messages Goto Initial 10 Messages

Copyright 2003-2021 Persistence of Vision Raytracer Pty. Ltd.