"Chris Cason" <del### [at] deletethistoopovrayorg> wrote in 
message news:48948066@news.povray.org...
> Jim Holsenback wrote:
>> Does the pov source file inherent the version from a sourced
>> include?
>
> I think you'll find that the includes set it back to the old value at the
> end (please check to make sure).

yes they do that ..... all but two of them

>
>> Maybe we need to up version the includes as well.
>
> There's probably no harm in doing so, and might even be a good idea 
> overall.

with the code frag in the includes this could be considered a moot point. In 
the name of housekeeping this may not be a bad idea to do this anyway. there 
are only 35 include files .... 33 are branded version 3.5 and have the 
switching mechinism, two files (stdcam.inc and stage1.inc) have 3.1 mention 
in header comments and no switching code. easy enough to version them as 3.7 
and housekeeping seems like a good reason to proceed, but won't do that 
unless you (Chris) think I should do this.

Jim

Post a reply to this message

"Jim Holsenback" <jho### [at] hotmailcom> wrote:
....
> i think we are getting close to starting to work, however there are some
> pending issues to be nailed down yet.
> here's a proposed breakdown:
>
> advanced/animations (71)
> camera/incdemo (74)
> interior/language/lights/objectmods/qtvr/radiosity (69)
> objects/portfolio (78)
> textures (73)
>
> Jim

If there are no objections I'll start to familiarise myself with the
'camera/incdemo' group.
When we seem to have agreed upon the requested changes, I'll start a new thread
for this group of files, so I can list my progress or problems.

Stephen S

Post a reply to this message

while having a look at the include files i think i may have come up with one 
more housekeeping issue that may be worthy of consideration.

the issue of the I_Glass warning .....

there are 14 scenes that call glass.inc (which calls glass_old.inc). my 
cleanup proposal involves making the textures in glass_old materials which 
would have the required inclusion of interior {I_Glass} and removing the 
I_Glass warning message in glass.inc .... oh and making a comment in 
glass_old header to call materials instead of textures.

I found at least one scene that calls the texture {T_Glass1} which is a 
glass_old texture, so it would appear there would be some changes to scene 
files as well.

comments welcome!

Jim

Post a reply to this message

"StephenS" <nomail@nomail> wrote in message 
news:web.489593a615676239d1f8364e0@news.povray.org...
> If there are no objections I'll start to familiarise myself with the
> 'camera/incdemo' group.
> When we seem to have agreed upon the requested changes, I'll start a new 
> thread
> for this group of files, so I can list my progress or problems.
>
> Stephen S
>
>
i'm cool wid dat

Post a reply to this message

I think we are close to wrapping up the review of v3.7 example scene files 
so I wanted to summarize and get our plan "blessed" before proceeding with 
the actual work.



Division of work: This is how the scenes have been divided up.

advanced/animations (71)
camera/incdemo (74)                (Stephen has already spoken up for this 
group)
interior/language/lights/objectmods/qtvr/radiosity (69)
objects/portfolio (78)
textures (73)



Image size and format: 768 x 576 (4:3 aspect ratio) PNG. Using the file 
advanced/grenadine as a test case I noticed a difference in the preview 
window image (to dark) and the final png image file (to light). This led me 
to believe that I hadn't set display_gamma correctly. After some empirical 
testing this is what I came up with for my quickres.ini file:



[768x576, AA 0.3]

Width=768

Height=576

Antialias=On

Antialias_Threshold=0.3

Display_Gamma=2.3



I'm going to post the image over in the images group. One last thing about 
image quality. The rim of the glass had jagged edges until I used +a0.1 
+r4 ... we DO want to resolve quality issues like that don't we?



Scene file edits: This is how assumed_gamma and source file versioning is 
handled.

This example (below) has an assumed_gamma setting, so in order to leverage 
off the 3.7 default behavior the #version 3.5 directive has been 
conditionally excluded, as well as the assumed_gamma setting in the global 
settings block. Additionally any mention of version in header comments have 
been deleted , and a date stamp with initials was added. Example files that 
don't have assumed_gamma in global settings block should be (if not already) 
branded #version 3.5 as the default behavior is gamma correction off.



---begin scene file frag

// Persistence of Vision Ray Tracer Scene Description File

// File: grenadine.pov

// Desc: Glass with liquid

// Date: 1999/06/04

// Auth: Ingo Janssen

//

// -w320 -h240

// -w800 -h600 +a0.3



// Updated: 04Aug2008(jh) for v3.7 distribution



#if (version < 3.6)

  #version 3.5

#end



#include "glass.inc"

#include "lemon.inc"



global_settings {

   // conditionally comply with gamma correction handling

   #if (version < 3.6)

        assumed_gamma 1.0

   #end

   max_trace_level 5

   photons {

      spacing 0.01  // higher value 'lower' quality, faster parsing.

      autostop 0

      jitter 0.5

      max_trace_level 15

  }

}

--- end scene file frag



Notice from the scene frag above that it calls and include "lemon.inc" which 
is an include in scenes/advanced. It had the #version directive in the body 
of that include. I used the following common version preservation method 
used in the application includes.



--- begin code frag

// Added to comply with common version preservation scheme

// 04Aug2008 (jh)

#ifndef(Lemon_Inc_Temp)

#declare Lemon_Inc_Temp=version;

#version 3.5;



#ifdef(View_POV_Include_Stack)

    #debug "including lemon.inc\n"

#end



// code body goes here



// Added to comply with common version preservation scheme

// 04Aug2008 (jh)

#version Lemon_Inc_Temp;

#end

--- end code frag



Include files review:

The include files have been reviewed and  since they have a scheme that 
keeps the calling source file from inheriting it's #version branding it's 
been suggested that this is a moot point to change the #version branding for 
now. In other words it's purely a housekeeping issue for now. Since we're on 
the topic of includes, I've heard no reply on my proposal to change the 
textures in glass_old.inc to materials, and remove the I_Glass warning in 
glass.inc. The above scene file frag calls glass.inc so a minor mod to the 
scene file was in order. The scene file rendered fine. I don't want to do 
this because silence implies agreement. Someone yea or nay this change 
please!



Have I forgotten anything?



Jim

Post a reply to this message

Jim Holsenback wrote:
> advanced/grenadine as a test case I noticed a difference in the preview 
> window image (to dark) and the final png image file (to light). This led me 

Please be aware that the PNG output images have the inverse gamma
written into the file header and will appear differently between
viewers that do and don't support using this value.

> I'm going to post the image over in the images group. One last thing about 
> image quality. The rim of the glass had jagged edges until I used +a0.1 
> +r4 ... we DO want to resolve quality issues like that don't we?

I suspect so, if it doesn't involve too much work.

> #if (version < 3.6)

Should that be < 3.6 or < 3.7 ?

> the topic of includes, I've heard no reply on my proposal to change the 
> textures in glass_old.inc to materials, and remove the I_Glass warning in 
> glass.inc. The above scene file frag calls glass.inc so a minor mod to the 
> scene file was in order. The scene file rendered fine. I don't want to do 
> this because silence implies agreement. Someone yea or nay this change 
> please!

I haven't read it in detail (during weekdays I don't get a lot of
time) but as long as it doesn't break any existing third-party scenes
I'm OK with the change.

thanks,

-- Chris

Post a reply to this message

"Chris Cason" <del### [at] deletethistoopovrayorg> wrote in 
message news:489a8737$1@news.povray.org...
> Jim Holsenback wrote:
>> advanced/grenadine as a test case I noticed a difference in the preview
>> window image (to dark) and the final png image file (to light). This led 
>> me
>
> Please be aware that the PNG output images have the inverse gamma
> written into the file header and will appear differently between
> viewers that do and don't support using this value.

yes .... i was using GIMP

>> I'm going to post the image over in the images group. One last thing 
>> about
>> image quality. The rim of the glass had jagged edges until I used +a0.1
>> +r4 ... we DO want to resolve quality issues like that don't we?
>
> I suspect so, if it doesn't involve too much work.
>
>> #if (version < 3.6)
>
> Should that be < 3.6 or < 3.7 ?

i defer to you .... i'll reread the doc and see if i can figure out what led 
me to believe that the default behavior for gamma correction has been around 
since 3.6.1

>
>> the topic of includes, I've heard no reply on my proposal to change the
>> textures in glass_old.inc to materials, and remove the I_Glass warning in
>> glass.inc. The above scene file frag calls glass.inc so a minor mod to 
>> the
>> scene file was in order. The scene file rendered fine. I don't want to do
>> this because silence implies agreement. Someone yea or nay this change
>> please!
>
> I haven't read it in detail (during weekdays I don't get a lot of
> time) but as long as it doesn't break any existing third-party scenes
> I'm OK with the change.

these scene files have glass.inc but MAY not call glass_old textures. i'll 
take ownership for making those changes.

./advanced/desk.pov
./advanced/grenadine.pov
./advanced/wineglass.pov
./advanced/woodbox.pov
./advanced/blocks/stackertransp.pov
./advanced/fish13/fish13.pov
./animations/boing/glsbng.pov
./incdemo/glasses/glass.pov
./incdemo/glasses/samp_demo.pov
./interior/ballbox1.pov
./interior/iortest.pov
./interior/magglass.pov
./lights/glassthing.pov
./lights/phot_met_glass.pov

Stephen I owe you two files as you're already working on the incdemo files. 
I'm going to speak up for the advanced/animations group of files. I will 
deal with the remaining files when someone speaks up for the groups that 
they are in. I will also post the revised glass/glass_old.inc files so both 
of you  (Stephen/Sabrina) can pick those up. Zip format OK? Give me a couple 
of days to get this done as I'm juggling several things (feast or famine) 
right now.

Jim

Post a reply to this message

"Jim Holsenback" <jho### [at] hotmailcom> wrote in message 
news:489ac9a9@news.povray.org...
> these scene files have glass.inc but MAY not call glass_old textures. i'll 
> take ownership for making those changes.
>
> ./advanced/desk.pov
> ./advanced/grenadine.pov
> ./advanced/wineglass.pov
> ./advanced/woodbox.pov
> ./advanced/blocks/stackertransp.pov
> ./advanced/fish13/fish13.pov
> ./animations/boing/glsbng.pov
> ./incdemo/glasses/glass.pov
> ./incdemo/glasses/samp_demo.pov
> ./interior/ballbox1.pov
> ./interior/iortest.pov
> ./interior/magglass.pov
> ./lights/glassthing.pov
> ./lights/phot_met_glass.pov

i posted these scene files as well as glass.inc and glass_old.inc are in a 
zip file over in the text.scene-files group

jim

Post a reply to this message

"Jim Holsenback" <jho### [at] hotmailcom> wrote in message 
news:489d58bf$1@news.povray.org...
>
> "Jim Holsenback" <jho### [at] hotmailcom> wrote in message 
> news:489ac9a9@news.povray.org...
>> these scene files have glass.inc but MAY not call glass_old textures. 
>> i'll take ownership for making those changes.
>>
>> ./advanced/desk.pov
>> ./advanced/grenadine.pov
>> ./advanced/wineglass.pov
>> ./advanced/woodbox.pov
>> ./advanced/blocks/stackertransp.pov
>> ./advanced/fish13/fish13.pov
>> ./animations/boing/glsbng.pov
>> ./incdemo/glasses/glass.pov
>> ./incdemo/glasses/samp_demo.pov
>> ./interior/ballbox1.pov
>> ./interior/iortest.pov
>> ./interior/magglass.pov
>> ./lights/glassthing.pov
>> ./lights/phot_met_glass.pov
>
> i posted these scene files as well as glass.inc and glass_old.inc are in a 
> zip file over in the text.scene-files group

i discovered a typo in comments that's been corrected ..... NEW zip file 
posted

Jim

Post a reply to this message

"Jim Holsenback" <jho### [at] hotmailcom> wrote in message 
news:489ac9a9@news.povray.org...
> I'm going to speak up for the advanced/animations group of files.

i'm done with edits of this section, and i've taking a different approach on 
my work flow. i'm going to just do edits for now as the render portion is 
going to be a bottleneck on my machine. most images rendered fairly quickly 
however some took > 1 hr at that rate i ought to finish up sometime before 
next summer ;-)

i'm going to start edits on this group:
interior/language/lights/objectmods/qtvr/radiosity

Jim

Post a reply to this message