POV-Ray : Newsgroups : povray.beta-test : Possible v3,8 b2ta 2 fix for "Borked diacritical marks" : Re: Possible v3,8 b2ta 2 fix for "Borked diacritical marks" Server Time
20 Apr 2024 06:34:23 EDT (-0400)
  Re: Possible v3,8 b2ta 2 fix for "Borked diacritical marks"  
From: jr
Date: 7 Apr 2023 07:30:00
Message: <web.642ffe31500c41f34301edef6cde94f1@news.povray.org>
hi,

William F Pokorny <ano### [at] anonymousorg> wrote:
> With respect to the "Borked diacritical marks" thread in
> povray.binaries.images.
> ...
> I believe, but I've not verified, the fix used for the povr fork will
> work with the current v3.8 beta 2 code.

no, alas.  see below.


> ...
> to this:
>
> //---
> #ifdef TTF_DEBUG
>              Debug_Info("sub_glyph %d:\n", sub_glyph_index);
> #endif
>
>              if (flags & ARG_1_AND_2_ARE_WORDS)
>              {
> #ifdef TTF_DEBUG
>                  Debug_Info("ARG_1_AND_2_ARE_WORDS\n");
> #endif
>                  if (flags & ARGS_ARE_XY_VALUES)
>                  {  // Values are int16_t
>                      arg1 = READSHORT(*ffile->file);
>                      arg2 = READSHORT(*ffile->file);
>                  }
>                  else
>                  {  // Values are uint16_t
>                      arg1 = READUSHORT(*ffile->file);
>                      arg1 = READUSHORT(*ffile->file);
>                  }
>              }
>              else

lost opening brace ?


in your 'povr' you made changes to the TrueTypeFont struct(ure), among them the
introduction of the 'file' member.
source/core/shape/truetype.h:125, in version _6e4ed6c2.

think this is really important, and useful, and so hope you will find the time
to "back-port".  (thank you, in advance)


regards, jr.


Post a reply to this message

Copyright 2003-2023 Persistence of Vision Raytracer Pty. Ltd.