POV-Ray : Newsgroups : povray.bugreports : pkgsrc patches for povray-3.6.1 : Re: pkgsrc patches for povray-3.6.1 Server Time
29 Apr 2024 21:04:01 EDT (-0400)
  Re: pkgsrc patches for povray-3.6.1  
From: Thomas Klausner
Date: 20 Jun 2010 13:35:00
Message: <web.4c1e512f9ac045b5a05a139b0@news.povray.org>
clipka <ano### [at] anonymousorg> wrote:
> Am 20.06.2010 00:40, schrieb Thomas Klausner:
> > Hi!
> >
> > pkgsrc contains a number of patches to povray-3.6.1.
>
> Note that the current versions are povray-3.6.2 and
> povray-3.7.0.beta.37a, and that current development versions may already
> include various other changes.

povray-3.6.2 is not available as sources for Unix, AFAICT. Am I missing
something?

> Did you verify that this is still backward compatible with earlier
> versions of libpng?

trans_alpha doesn't exist for png<1.4, so if you still want to support earlier
versions, something like
#if PNG_LIBPNG_VER < 10400
#define trans_alpha trans
#endif
is needed.

> Such a change has already been implemented in change #4827 for the
> POV-Ray 3.6 branch (unfortunately just a few days late for 3.6.2); in
> the POV-Ray 3.7 branch, there is neither such a file, nor such functions
> as far as I can see.

Good to hear that.

> This has also been fixed in change #4827, and also in 3.7.0.beta.31.

Very good.

> > Please include the patches in the next release!
>
> I guess the developers will not respond too well to such requests,
> especially when accompanied by exclamation marks. For future code
> submissions, you may want to try submitting (A) a detailed problem
> report (preferably on bugs.povray.org), accompanied by (B) a solution
> /proposal/, rather than a demand.

I'm sorry if the exclamation mark made you think of my request as a demand, it
was not meant in that way.

Thanks for the pointer to bugs.povray.org, I didn't find it when browsing for
where to report bugs. Do you think it would be useful to report the png problem
there (with exclamation marks this time :) )?

Thanks for your help,
 Thomas


Post a reply to this message

Copyright 2003-2023 Persistence of Vision Raytracer Pty. Ltd.