I'm just trying to compile megapov 0.3 again. It still doesn't work without
modifying the code.
  There are //-comments at:
  - line 232 of f_expr.c
  - line 2679 of pattern.c
  There are undeclared 'false' and 'true' variables in isosurf.c at
lines 1370, 1371 and 1378.


  May I suggest a couple of things?

  1) Would it make harm to other platforms (ie. windows) if the following
messages in photons.c:
  Status_Info ("\nBuilding Photon Maps... this=%d, total=%d, ...
  Status_Info ("\nSorting photons... %d",end);
were changed to:
  Status_Info ("\rBuilding Photon Maps... this=%d, total=%d, ...
  Status_Info ("\rSorting photons... %d",end);
?
  The latter is better for unix.

  2) Could you rename all the source files to lowercase? I have to do it
myself every time I download a new version. It's easy to do with the proper
command (namely: for FILE (*.c *.h) mv "$FILE" "${(L)$(echo $FILE)}") but I
think it would be better if they were in lowercase already.


  This is a list of warnings which still are issued (I skipped the "unused
parameter", "possible use of uninitialized variable" and "static declaration
follows non-static" warnings):

bbox.c:907: warning: suggest parentheses around && within ||
bezier2.c:784: warning: suggest explicit braces to avoid ambiguous `else'
bezier2.c:797: warning: suggest explicit braces to avoid ambiguous `else'
express.c:442: warning: suggest parentheses around comparison in operand of &
express.c:681: warning: comparison between signed and unsigned
express.c:2860: warning: comparison between signed and unsigned
express.c:3001: warning: comparison between signed and unsigned
express.c:3031: warning: comparison between signed and unsigned
f_expr.c:101: warning: overflow in implicit constant conversion
f_expr.c:521: warning: suggest explicit braces to avoid ambiguous `else'
f_expr.c:538: warning: suggest explicit braces to avoid ambiguous `else'
f_func.c:280: warning: implicit declaration of function `asinh'
f_func.c:292: warning: implicit declaration of function `acosh'
f_func.c:304: warning: implicit declaration of function `atanh'
isoblob.h:147: warning: file does not end in newline
isoblob.c:2959: warning: file does not end in newline
isofunc.c:1051: warning: missing braces around initializer
isofunc.c:1051: warning: (near initialization for `func_table[0]')
isosurf.c:154: warning: comparison between signed and unsigned
isosurf.c:155: warning: comparison between signed and unsigned
isosurf.c:1242: warning: comparison between signed and unsigned
lighting.c: warning: 1 trigraph(s) encountered
mem.c:871: warning: comparison of unsigned expression < 0 is always false
optin.c:1464: warning: suggest explicit braces to avoid ambiguous `else'
parse.c:7895: warning: suggest parentheses around assignment used as truth value
pattern.c:112: warning: `/*' within comment
pattern.c:113: warning: `/*' within comment
photons.c:1236: warning: `/*' within comment
png_pov.c:1559: warning: comparison between signed and unsigned
png_pov.c:1570: warning: comparison between signed and unsigned
png_pov.c:1596: warning: comparison between signed and unsigned
png_pov.c:1615: warning: comparison between signed and unsigned
png_pov.c:1632: warning: comparison between signed and unsigned
png_pov.c:1649: warning: comparison between signed and unsigned
povray.c:1499: warning: `/*' within comment
povray.c:2067: warning: statement with no effect
povray.c:2076: warning: statement with no effect
povray.c:2082: warning: statement with no effect
povray.c:2100: warning: statement with no effect
povray.c:2112: warning: statement with no effect
povray.c:2121: warning: statement with no effect
radiosit.c:448: warning: `/*' within comment
radiosit.c:449: warning: `/*' within comment
radiosit.c:1373: warning: `/*' within comment
rbezier.c:896: warning: suggest explicit braces to avoid ambiguous `else'
rbezier.c:909: warning: suggest explicit braces to avoid ambiguous `else'
rbezier.c:1426: warning: suggest explicit braces to avoid ambiguous `else'
rbezier.c:1508: warning: suggest explicit braces to avoid ambiguous `else'
render.c:1844: warning: suggest parentheses around && within ||
sphsweep.c:126: warning: missing braces around initializer
sphsweep.c:126: warning: (near initialization for `Catmull_Rom_Matrix[0]')
sphsweep.c:134: warning: missing braces around initializer
sphsweep.c:134: warning: (near initialization for `B_Matrix[0]')
tokenize.c:4044: warning: empty body in an if-statement
truetype.c:1820: warning: comparison between signed and unsigned
vbuffer.c:574: warning: suggest parentheses around && within ||


-- 
main(i,_){for(_?--i,main(i+2,"FhhQHFIJD|FQTITFN]zRFHhhTBFHhhTBFysdB"[i]
):5;i&&_>1;printf("%s",_-70?_&1?"[]":" ":(_=0,"\n")),_/=2);} /*- Warp -*/

Post a reply to this message

Thanks for the suggestions.  I'll try to take care of these for you unix
guys before the next release.  The changes from '\n' to '\r' should not have
any effect on windows, so I'll change them.  To bad renaming files to
lowercase in Windows is not as easy as it is for you.

-Nathan

Nieminen Juha <war### [at] punarastascstutfi> wrote...
>   I'm just trying to compile megapov 0.3 again. It still doesn't work
without
> modifying the code.
>   There are file://-comments at:
>   - line 232 of f_expr.c
>   - line 2679 of pattern.c
>   There are undeclared 'false' and 'true' variables in isosurf.c at
> lines 1370, 1371 and 1378.
>
>
>   May I suggest a couple of things?
>
>   1) Would it make harm to other platforms (ie. windows) if the following
> messages in photons.c:
>   Status_Info ("\nBuilding Photon Maps... this=%d, total=%d, ...
>   Status_Info ("\nSorting photons... %d",end);
> were changed to:
>   Status_Info ("\rBuilding Photon Maps... this=%d, total=%d, ...
>   Status_Info ("\rSorting photons... %d",end);
> ?
>   The latter is better for unix.
>
>   2) Could you rename all the source files to lowercase? I have to do it
> myself every time I download a new version. It's easy to do with the
proper
> command (namely: for FILE (*.c *.h) mv "$FILE" "${(L)$(echo $FILE)}") but
I
> think it would be better if they were in lowercase already.
>
>
>   This is a list of warnings which still are issued (I skipped the "unused
> parameter", "possible use of uninitialized variable" and "static
declaration
> follows non-static" warnings):
>
> bbox.c:907: warning: suggest parentheses around && within ||
> bezier2.c:784: warning: suggest explicit braces to avoid ambiguous `else'
> bezier2.c:797: warning: suggest explicit braces to avoid ambiguous `else'
> express.c:442: warning: suggest parentheses around comparison in operand
of &
> express.c:681: warning: comparison between signed and unsigned
> express.c:2860: warning: comparison between signed and unsigned
> express.c:3001: warning: comparison between signed and unsigned
> express.c:3031: warning: comparison between signed and unsigned
> f_expr.c:101: warning: overflow in implicit constant conversion
> f_expr.c:521: warning: suggest explicit braces to avoid ambiguous `else'
> f_expr.c:538: warning: suggest explicit braces to avoid ambiguous `else'
> f_func.c:280: warning: implicit declaration of function `asinh'
> f_func.c:292: warning: implicit declaration of function `acosh'
> f_func.c:304: warning: implicit declaration of function `atanh'
> isoblob.h:147: warning: file does not end in newline
> isoblob.c:2959: warning: file does not end in newline
> isofunc.c:1051: warning: missing braces around initializer
> isofunc.c:1051: warning: (near initialization for `func_table[0]')
> isosurf.c:154: warning: comparison between signed and unsigned
> isosurf.c:155: warning: comparison between signed and unsigned
> isosurf.c:1242: warning: comparison between signed and unsigned
> lighting.c: warning: 1 trigraph(s) encountered
> mem.c:871: warning: comparison of unsigned expression < 0 is always false
> optin.c:1464: warning: suggest explicit braces to avoid ambiguous `else'
> parse.c:7895: warning: suggest parentheses around assignment used as truth
value
> pattern.c:112: warning: `/*' within comment
> pattern.c:113: warning: `/*' within comment
> photons.c:1236: warning: `/*' within comment
> png_pov.c:1559: warning: comparison between signed and unsigned
> png_pov.c:1570: warning: comparison between signed and unsigned
> png_pov.c:1596: warning: comparison between signed and unsigned
> png_pov.c:1615: warning: comparison between signed and unsigned
> png_pov.c:1632: warning: comparison between signed and unsigned
> png_pov.c:1649: warning: comparison between signed and unsigned
> povray.c:1499: warning: `/*' within comment
> povray.c:2067: warning: statement with no effect
> povray.c:2076: warning: statement with no effect
> povray.c:2082: warning: statement with no effect
> povray.c:2100: warning: statement with no effect
> povray.c:2112: warning: statement with no effect
> povray.c:2121: warning: statement with no effect
> radiosit.c:448: warning: `/*' within comment
> radiosit.c:449: warning: `/*' within comment
> radiosit.c:1373: warning: `/*' within comment
> rbezier.c:896: warning: suggest explicit braces to avoid ambiguous `else'
> rbezier.c:909: warning: suggest explicit braces to avoid ambiguous `else'
> rbezier.c:1426: warning: suggest explicit braces to avoid ambiguous `else'
> rbezier.c:1508: warning: suggest explicit braces to avoid ambiguous `else'
> render.c:1844: warning: suggest parentheses around && within ||
> sphsweep.c:126: warning: missing braces around initializer
> sphsweep.c:126: warning: (near initialization for `Catmull_Rom_Matrix[0]')
> sphsweep.c:134: warning: missing braces around initializer
> sphsweep.c:134: warning: (near initialization for `B_Matrix[0]')
> tokenize.c:4044: warning: empty body in an if-statement
> truetype.c:1820: warning: comparison between signed and unsigned
> vbuffer.c:574: warning: suggest parentheses around && within ||
>
>
> --
> main(i,_){for(_?--i,main(i+2,"FhhQHFIJD|FQTITFN]zRFHhhTBFHhhTBFysdB"[i]
> ):5;i&&_>1;printf("%s",_-70?_&1?"[]":" ":(_=0,"\n")),_/=2);} /*- Warp -*/

Post a reply to this message

Nathan Kopp wrote:
> 
> Thanks for the suggestions.  I'll try to take care of these for you unix
> guys before the next release.  The changes from '\n' to '\r' should not have
> any effect on windows, so I'll change them.  To bad renaming files to
> lowercase in Windows is not as easy as it is for you.
> 
> -Nathan
> 
	BTW, how do you make the .zip file? Under unix, there's a parameter to
the unzip command that will convert the names to lowercase as it
extracts the files, but it didn't work with any of the uvpov sources
that I've tried (haven't tried megapov under linux yet) thoug it worked
once I went to win and remade the zip with winzip...

		Jerome
-- 
*******************************

* they'll tell you what can't * mailto:ber### [at] inamecom
* be done and why...          * http://www.enst.fr/~jberger
* Then do it.                 *
*******************************

Post a reply to this message

In article <3861A224.589F540F@enst.fr> , "Jerome M. BERGER" 
<jbe### [at] enstfr> wrote:

>  BTW, how do you make the .zip file? Under unix, there's a parameter to
> the unzip command that will convert the names to lowercase as it
> extracts the files, but it didn't work with any of the uvpov sources
> that I've tried (haven't tried megapov under linux yet) thoug it worked
> once I went to win and remade the zip with winzip...

That sounds familiar, I am using such a command on the Mac to make sure zip
archives contain lowercase filenames when I wan them.  I suspect that other
zip/unzip versions offer similar features, well hidden in the documentation
:-)


       Thorsten


____________________________________________________
Thorsten Froehlich, Duisburg, Germany
e-mail: tho### [at] trfde

Visit POV-Ray on the web: http://mac.povray.org

Post a reply to this message