"Jim Holsenback" <jho### [at] hotmailcom> wrote in message 
news:48a2b9c9@news.povray.org...
> Stephen & Sabrina: I'm done with all my edits and have rendered all the 
> files in the textures directory.

I'm all done with these sections (edits & renders) ....

advanced/animations (71)
interior/language/lights/objectmods/qtvr/radiosity (69)
textures (73)

1. there were less than half dozen files that required differnt aspect ratio 
other than 4:3

2. a couple of files were order dependant (error because it was looking for 
a image file that hadn't been rendered yet)

3. advanced/fish13/fish.inc and stem1.inc had #version 1.0 set. I left 
fih.inc at #version 1.0 (comma's between vector coords?) upgraded stem1.inc 
to #version 3.5 and replaced alpha with filter. left world12.inc alone as it 
had no #version.

4. modified glass.inc and glass_old.inc (textures-> materials)

5. assumed_gamma handling was by far the dominate issue.

Jim

Post a reply to this message

Stephen,

I've set up a FTP account for the scenes but don't have your email
address handy ATM. Please drop me an email and I'll pass on the login
details.

-- Chris

Post a reply to this message

"Jim Holsenback" <jho### [at] hotmailcom> wrote:
....
Sorry for taking so long, I have been struggling a bit, but seem to be going
fine now. This post by Jim has helped.
> [768x576, AA 0.3]
>
> Width=768
>
> Height=576
>
> Antialias=On
>
> Antialias_Threshold=0.3
>
> Display_Gamma=2.3
....
I'm using this in quickres.ini to help:

[768x576, AA 0.3, png]
Width=768
Height=576
Antialias=On
Antialias_Threshold=0.3
Output_File_Type = n

> // Updated: 04Aug2008(jh) for v3.7 distribution
>
>
>
> #if (version < 3.6)
>
>   #version 3.5
>
> #end
>
>
>
> #include "glass.inc"
>
> #include "lemon.inc"
>
>
>
> global_settings {
>
>    // conditionally comply with gamma correction handling
>
>    #if (version < 3.6)
>
>         assumed_gamma 1.0
>
>    #end
>
....
I'm using a version of this in the scene file:

// Updated: Aug2008(sjs) for version and gamma
// -w768 -h576 +a0.3 Output_File_Type=n Display_Gamma=1
#if (version < 3.7)
  #version 3.6;
  global_settings { assumed_gamma 2.2 }
#end

Stephen S

Post a reply to this message

"Chris Cason" <del### [at] deletethistoopovrayorg> wrote in 
message news:48a7e19a@news.povray.org...
> Jim Holsenback wrote:
>> Stephen & Sabrina: I'm done with all my edits and have rendered all the
>> files in the textures directory.
>>
>> Chris: do you have some disc space that we can start putting the scene
>> source files and images?
>
> Sorry, only just now catching up with group: yes, I'll set something up.
>
> -- Chris

I'm all done .... source, ini and png files have been uploaded to ftp site.

Jim

Post a reply to this message

Jim Holsenback wrote:
> "Chris Cason" <del### [at] deletethistoopovrayorg> wrote in 
> message news:48a7e19a@news.povray.org...
>> Jim Holsenback wrote:
>>> Stephen & Sabrina: I'm done with all my edits and have rendered all the
>>> files in the textures directory.
>>>
>>> Chris: do you have some disc space that we can start putting the scene
>>> source files and images?
>> Sorry, only just now catching up with group: yes, I'll set something up.
>>
>> -- Chris
> 
> I'm all done .... source, ini and png files have been uploaded to ftp site.
> 
> Jim 
> 
> 

This weekend has turned awful, and extended till midweek. I've got the 
edits, just need to find time to upload them.

Post a reply to this message

Jim Holsenback wrote:
> while having a look at the include files i think i may have come up with one 
> more housekeeping issue that may be worthy of consideration.
> 
> the issue of the I_Glass warning .....
> 
> there are 14 scenes that call glass.inc (which calls glass_old.inc). my 
> cleanup proposal involves making the textures in glass_old materials which 
> would have the required inclusion of interior {I_Glass} and removing the 
> I_Glass warning message in glass.inc .... oh and making a comment in 
> glass_old header to call materials instead of textures.

Jim,

About the change of glass textures to materials: we need some provision for
backward compatibility, otherwise lots of old scenes will be busted
(includes some in the distro; e.g. woodbox.pov).

Suggestions?

-- Chris

Post a reply to this message

"Chris Cason" <del### [at] deletethistoopovrayorg> wrote in 
message news:48d60e3d@news.povray.org...
> Jim Holsenback wrote:
>> while having a look at the include files i think i may have come up with 
>> one
>> more housekeeping issue that may be worthy of consideration.
>>
>> the issue of the I_Glass warning .....
>>
>> there are 14 scenes that call glass.inc (which calls glass_old.inc). my
>> cleanup proposal involves making the textures in glass_old materials 
>> which
>> would have the required inclusion of interior {I_Glass} and removing the
>> I_Glass warning message in glass.inc .... oh and making a comment in
>> glass_old header to call materials instead of textures.
>
> Jim,
>
> About the change of glass textures to materials: we need some provision 
> for
> backward compatibility, otherwise lots of old scenes will be busted
> (includes some in the distro; e.g. woodbox.pov).
>
> Suggestions?
>
> -- Chris

I did change ALL distro scenes that called any glass textures the old way. 
Are you talking about a personal scene that someone created with application 
version less than 3.7? I thought that the error that the parser would throw 
would eventually lead them to the glass.inc file where a notation was made 
about the change was enough to ween everyone off the old way. If that's not 
the case, how about something like we did with the assumed_gamma handling in 
the globals block? Personally anytime I called glass.inc definitions I found 
the parser warning annoying and copied the definition (with appropriate 
I_Glass) into my scene and didn't bother even sourcing the glass.inc file at 
all. As I was looking at distro scenes that had glass.inc some of the 
authors had already done that. At any rate if you feel the needs a closer 
look I'll do that. At first glance I'm thinking something like:

if (version < 3.7)
  make them textures
  issue I_Glass warning
else
  make them materials
end

but haven't explored the gotcha's of this yet.

Jim

Post a reply to this message

Jim Holsenback wrote:
> I did change ALL distro scenes that called any glass textures the old way. 

I think you missed woodbox.pov then:] (either that or I didn't update
it for some reason).

> Are you talking about a personal scene that someone created with application 
> version less than 3.7? I thought that the error that the parser would throw 

Basically any pre-existing scene. With upgrades to POV-Ray we've
always had a policy of not breaking pre-existing scenes except where
absolutely necessary. So we ought to provide backwards compatibility.
Technically there's probably no reason why both schemes can't live
alongside each other.

> if (version < 3.7)
>   make them textures
>   issue I_Glass warning
> else
>   make them materials
> end

While I'd like to see a warning issued, the problem would be that
anyone with a pre-3.7 scene loading the include file (even if they
don't use the glass textures) would get the warning ... I expect some
scenes out there do include files that they don't use, and would thus
get this warning. Also, anyone running an old scene without a #version
set would get a parse failure on the missing textures.

I think we need to provide both for the meantime. Perhaps we also then
need something like the 'deprecated' warning that is available in
compilers; we can declare something deprecated (via SDL) and if it is
used in a scene the parser spits out a warning.

-- Chris

Post a reply to this message

Chris Cason wrote:
> While I'd like to see a warning issued, the problem would be that
> anyone with a pre-3.7 scene loading the include file (even if they
> don't use the glass textures) would get the warning ...

Doesn't that already happen if you include glass.inc in 3.6? I get a warning
even if the scene doesn't use the old glass textures.

Post a reply to this message

Nicolas Alvarez wrote:
> Doesn't that already happen if you include glass.inc in 3.6? I get a warning
> even if the scene doesn't use the old glass textures.

Yes, and it's one of the things we are fixing in the updated files.

-- Chris

Post a reply to this message