Two words:

Legacy code.

-Nathan

"Michael Andrews" <m.c### [at] readingacuk> wrote...
> Michael Andrews wrote:
> > On a related theme, in the same function there is a block starting at
> > line 1179 which calculates 'gather_grey' from 'Radiosity_Gather_Total'
> > and 'Radiosity_Gather_Total_Count'.
>
> OK, now I'm confused.
>
> I had a look for these variables in the source:
>
> $ grep -n 'Radiosity_Gather_Total' *.cpp
> octree.cpp:1082:    Make_Colour(Radiosity_Gather_Total, 0., 0., 0.);
> octree.cpp:1083:    Radiosity_Gather_Total_Count = 0;
> radiosit.cpp:110:COLOUR Radiosity_Gather_Total;
> radiosit.cpp:111:long Radiosity_Gather_Total_Count;
> radiosit.cpp:837:    VAddEq(Radiosity_Gather_Total, Illuminance);
> radiosit.cpp:838:    Radiosity_Gather_Total_Count++;
> render.cpp:967:  Make_Colour(Radiosity_Gather_Total, 0.0, 0.0, 0.0);
> render.cpp:968:  Radiosity_Gather_Total_Count = 0;
> render.cpp:1185:      if ( Radiosity_Gather_Total_Count )
> render.cpp:1187:        VInverseScale(avg_gather,
> Radiosity_Gather_Total,  (DBL)Radiosity_Gather_Total_Count);
>
> $ grep -n 'Radiosity_Gather_Total' *.h
> radiosit.h:89:extern COLOUR Radiosity_Gather_Total;
> radiosit.h:90:extern long Radiosity_Gather_Total_Count;
>
> $ grep -n 'avg_gather' *.cpp
> render.cpp:957:  COLOUR Colour, avg_gather;
> render.cpp:1187:        VInverseScale(avg_gather,
> Radiosity_Gather_Total,  (DBL)Radiosity_Gather_Total_Count);
> render.cpp:1188:        gather_grey  = avg_gather[pRED]  +
> avg_gather[pGREEN]  + avg_gather[pBLUE];
>
> $ grep -n 'gather_grey' *.cpp
> render.cpp:956:  DBL grey, gather_grey;
> render.cpp:1188:        gather_grey  = avg_gather[pRED]  +
> avg_gather[pGREEN]  + avg_gather[pBLUE];
> render.cpp:1189:        if ( gather_grey > 0. )
> render.cpp:1193:          /*opts.Radiosity_Brightness = 3. /
> gather_grey; */
>
> Looking at the code I can not see that these variables do anything. Am I
> wrong?
>
> Could someone please tell me what does effect the automatic radiosity
> brightness adjustment?
>
> A very puzzled,
> Mike Andrews.

Post a reply to this message