|
![](/i/fill.gif) |
Frits van Bommel wrote:
> Thanks, great work. Just one comment:
>
> #macro xyz(px,py,pz)
> #local vx = vrotate(vrotate(vrotate(x,px*x),py*y),pz*z);
> #local vy = vrotate(vrotate(vrotate(y,px*x),py*y),pz*z);
> #local vz = vrotate(vrotate(vrotate(z,px*x),py*y),pz*z);
> getrotation(vx,vy,vz)
> #end
>
> could be done somewhat shorter like this
>
> #macro xyz(px,py,pz)
> <px,py,pz>
> #end
>
> ;-)
> I imagine this is also faster, especially when used a lot.
>
> Frits van Bommel
>
You're absolutely right.
I guess I got caught up in the uniformity of it.
On the other hand, I guess I thought that particular one
wouldn't get used much, anyway.
At least when I'm doing rotations, if I want the order to
be x,y,z I just use a straight vector.
--
Tom Bates
Post a reply to this message
|
![](/i/fill.gif) |