POV-Ray : Newsgroups : povray.programming : Q: Are the 'generic' sources no longer kept generic? : Re: Q: Are the 'generic' sources no longer kept generic? Server Time
28 Jul 2024 22:31:26 EDT (-0400)
  Re: Q: Are the 'generic' sources no longer kept generic?  
From: Thorsten Froehlich
Date: 27 Apr 1999 14:21:39
Message: <3725f223.0@news.povray.org>
In article <3725DC9E.26EBEB5A@remove-this.reading.ac.uk> , Michael Andrews
<M.C### [at] remove-thisreadingacuk>  wrote:
>  At this (partial) success I unzipped the windows source to have a look
> at how much work it would be to build a make file for the windows
> specific source. Didn't like what I saw (I've done no Windows
> programming at all -  resources? wozzat?) and went to get a coffee.

Well, that is the Windows specific code, it is _clearly_ separated in an
extra directory. How else do you think there can be a Windows front-end?
If you look into the other archives, you will find a DOS, Mac OS, etc
front-end.

>  Upon acquiring my caffeine fix I decided to recompile the unix source
> after tweaking the compiler settings. And the compile fell over with a
> parse error in tokenize.c.
>  I had a look and found that the offending line was a C++ style comment.

Then you have an old compiler or wrong setting, the (newer) ISO C standard
allows // comments in C - deactivating ANSI strict options helps for most
compilers. Or you simply switch to C++ mode of your compiler, the source is
C++ compatible.

> On the following line was a windows specific function call.

That is why each system distribution comes with an extra source archive.
There are a _few_ (less than five or so) changes that sometimes did not make
it into the generic code in time. It will then most likely be cleaned up in
the next major release.

>  So, I extracted tokenize.c from the unix tar file and recompiled with
> the original compiler settings. And the compile fell over with a
> multitude of compile/link errors.

Just removing the line would have done. You shouldn't get that many compiler
errors, something must have gone wrong :-)

>  And so I get back to my opening query: Are the 'generic' sources to
> PoV-Ray no longer being kept generic? Is there going to be a final
> parting of the ways between different sets of source code? Am I over
> reacting?

Yes!!!!!

>  I would not be surprised to find that they can no longer be generic. It
> is just that I had heard nothing in these news groups about other people
> finding this discrepancy between source code sets.
>  My primary concern is for people writing source code patches. The
> reason I was looking into compiling the source code myself was that I
> wished to tweak the Photon Patch in a couple of ways. So I looked at the
> source code provided for this and saw that it appeared to be based on
> the Windows 'generic' source.

As said, just a few lines over the whole source code, easy to clean up:
Remove them! Don't worry :-)


    Thorsten


Post a reply to this message

Copyright 2003-2023 Persistence of Vision Raytracer Pty. Ltd.