POV-Ray : Newsgroups : povray.beta-test : A bug in shapes.inc? Server Time
1 Jun 2024 19:31:12 EDT (-0400)
  A bug in shapes.inc? (Message 4 to 13 of 13)  
<<< Previous 3 Messages Goto Initial 10 Messages
From: Le Forgeron
Subject: Re: A bug in shapes.inc?
Date: 18 May 2011 04:06:29
Message: <4dd37e05@news.povray.org>
Le 18/05/2011 09:15, Thomas de Groot a écrit :
>> The maximum resident size was 2 161 776 kilobytes. Might be an issue for
>> > 32 bits systems. (that's a bit more than 2 Giga, usual issue for 32 bits
>> > program)
>> > What is your system ?
> Yes, the size of the output might be a problem indeed. In general, I want to 
> keep my mesh2 files well under the 100Mb.
> 
> My system is an 32 bits WinXP-SP3, 3GHz, dual core machine.
> 
So the maximal address space for user data & code is 2 Giga (the 32th
bit is used on that system to reach the kernel space and other fancy zone).

No hope for that scene on that system. Sorry.


Post a reply to this message

From: Thomas de Groot
Subject: Re: A bug in shapes.inc?
Date: 18 May 2011 04:18:55
Message: <4dd380ef$1@news.povray.org>
"Le_Forgeron" <jgr### [at] freefr> schreef in bericht 
news:4dd2a7cf$1@news.povray.org...
> The update should be done in the #Write of HFCreate_, to replace
> xRes*zRes with
> xRes,"*",zRes
>
> (and
> (xRes-1)*(zRes-1)*2 with
> (xRes-1),"*",(zRes-1),"*2"
> ) (if you get the spirit of it ?)

This is not really necessary in fact.

> There already some double while-loop used to dump the vectors, so adding
> a "\n" under #if(WriteFile) might already ease the output file.
> (well, instead of 1 line of 1 million vectors... 1000 lines of 1000
> vectors each... is that better ?)

Better is to replace:
        PArr[J][K],
with:
        #if(WriteFile)
          PArr[J][K],"\n",
        #else
          PArr[J][K],
        #end

And:
             vnormalize(vcross(PArr[J][K+1]-PArr[J][K-1], 
PArr[J+1][K]-PArr[J-1][K])),
with:
           #if(WriteFile)
             vnormalize(vcross(PArr[J][K+1]-PArr[J][K-1], 
PArr[J+1][K]-PArr[J-1][K])),"\n",
           #else
             vnormalize(vcross(PArr[J][K+1]-PArr[J][K-1], 
PArr[J+1][K]-PArr[J-1][K])),
           #end

And:
             <(J-1)/(xRes-1),(K-1)/(zRes-1)>,
with:
           #if(WriteFile)
             <(J-1)/(xRes-1),(K-1)/(zRes-1)>,"\n",
           #else
             <(J-1)/(xRes-1),(K-1)/(zRes-1)>,
           #end

And finally:
          F1+A, F2+A,
with:
        #if(WriteFile)
          F1+A, F2+A,"\n",
        #else
          F1+A, F2+A,
        #end

This works fine.

Thomas


Post a reply to this message

From: Thomas de Groot
Subject: Re: A bug in shapes.inc?
Date: 18 May 2011 04:22:34
Message: <4dd381ca@news.povray.org>
"Le_Forgeron" <lef### [at] freefr> schreef in bericht 
news:4dd37e05@news.povray.org...
> No hope for that scene on that system. Sorry.

Indeed. It is to find the balance where everything still works fine....

Thomas


Post a reply to this message

From: Jim Holsenback
Subject: Re: A bug in shapes.inc?
Date: 18 May 2011 05:41:12
Message: <4dd39438$1@news.povray.org>
On 05/18/2011 05:17 AM, Thomas de Groot wrote:
> "Le_Forgeron"<jgr### [at] freefr>  schreef in bericht
> news:4dd2a7cf$1@news.povray.org...
>> The update should be done in the #Write of HFCreate_, to replace
>> xRes*zRes with
>> xRes,"*",zRes
>>
>> (and
>> (xRes-1)*(zRes-1)*2 with
>> (xRes-1),"*",(zRes-1),"*2"
>> ) (if you get the spirit of it ?)
>
> This is not really necessary in fact.
>
>> There already some double while-loop used to dump the vectors, so adding
>> a "\n" under #if(WriteFile) might already ease the output file.
>> (well, instead of 1 line of 1 million vectors... 1000 lines of 1000
>> vectors each... is that better ?)
>
> Better is to replace:
>          PArr[J][K],
> with:
>          #if(WriteFile)
>            PArr[J][K],"\n",
>          #else
>            PArr[J][K],
>          #end
>
> And:
>               vnormalize(vcross(PArr[J][K+1]-PArr[J][K-1],
> PArr[J+1][K]-PArr[J-1][K])),
> with:
>             #if(WriteFile)
>               vnormalize(vcross(PArr[J][K+1]-PArr[J][K-1],
> PArr[J+1][K]-PArr[J-1][K])),"\n",
>             #else
>               vnormalize(vcross(PArr[J][K+1]-PArr[J][K-1],
> PArr[J+1][K]-PArr[J-1][K])),
>             #end
>
> And:
>               <(J-1)/(xRes-1),(K-1)/(zRes-1)>,
> with:
>             #if(WriteFile)
>               <(J-1)/(xRes-1),(K-1)/(zRes-1)>,"\n",
>             #else
>               <(J-1)/(xRes-1),(K-1)/(zRes-1)>,
>             #end
>
> And finally:
>            F1+A, F2+A,
> with:
>          #if(WriteFile)
>            F1+A, F2+A,"\n",
>          #else
>            F1+A, F2+A,
>          #end
>
> This works fine.
>
> Thomas
>
>
I recently fixed warning messages that the Bevelled_Text macro (also in 
shapes.inc) was spitting out (unnecessary bounding), so when you're 
happy with the repairs you've made, attach the updated file in 
p.t.scene-files and I'll make sure it gets into the distribution.

Jim


Post a reply to this message

From: Thomas de Groot
Subject: Re: A bug in shapes.inc?
Date: 18 May 2011 10:10:19
Message: <4dd3d34b$1@news.povray.org>
"Jim Holsenback" <jho### [at] povrayorg> schreef in bericht 
news:4dd39438$1@news.povray.org...
> I recently fixed warning messages that the Bevelled_Text macro (also in 
> shapes.inc) was spitting out (unnecessary bounding), so when you're happy 
> with the repairs you've made, attach the updated file in p.t.scene-files 
> and I'll make sure it gets into the distribution.
>

Excellent. I have now also added the *missing* commas. Not really necessary 
of course, but it appeals to my sense of *correctness* so to speak :-)

Only for the face_indices block, have I not been able to write the last 
vector without a comma.. Nonetheless, I shall put this version of shapes.inc 
in p.t.scene-files. If somebody can solve this small problem, let us know.

Thomas


Post a reply to this message

From: Le Forgeron
Subject: Re: A bug in shapes.inc?
Date: 18 May 2011 10:12:24
Message: <4dd3d3c8$1@news.povray.org>
Le 18/05/2011 16:10, Thomas de Groot a écrit :
> "Jim Holsenback" <jho### [at] povrayorg> schreef in bericht 
> news:4dd39438$1@news.povray.org...
>> I recently fixed warning messages that the Bevelled_Text macro (also in 
>> shapes.inc) was spitting out (unnecessary bounding), so when you're happy 
>> with the repairs you've made, attach the updated file in p.t.scene-files 
>> and I'll make sure it gets into the distribution.
>>
> 
> Excellent. I have now also added the *missing* commas. Not really necessary 
> of course, but it appeals to my sense of *correctness* so to speak :-)
> 
> Only for the face_indices block, have I not been able to write the last 
> vector without a comma.. Nonetheless, I shall put this version of shapes.inc 
> in p.t.scene-files. If somebody can solve this small problem, let us know.

Silly trick: the comma is not after the vector, but before it...
just my 0.02€ (Tax Not Included)


-- 
Software is like dirt - it costs time and money to change it and move it
around.


Just because you can't see it, it doesn't weigh anything,
and you can't drill a hole in it and stick a rivet into it doesn't mean
it's free.


Post a reply to this message

From: Thomas de Groot
Subject: Re: A bug in shapes.inc?
Date: 18 May 2011 10:17:47
Message: <4dd3d50b@news.povray.org>
"Le_Forgeron" <lef### [at] freefr> schreef in bericht 
news:4dd3d3c8$1@news.povray.org...
> Silly trick: the comma is not after the vector, but before it...
> just my 0.02? (Tax Not Included)

oh, right.... never thought of that trick... I shall have to try this out 
first though...

Thanks for this :-)

Thomas


Post a reply to this message

From: Thomas de Groot
Subject: Re: A bug in shapes.inc?
Date: 18 May 2011 10:51:22
Message: <4dd3dcea$1@news.povray.org>
"Le_Forgeron" <lef### [at] freefr> schreef in bericht 
news:4dd3d3c8$1@news.povray.org...

> Silly trick: the comma is not after the vector, but before it...
> just my 0.02? (Tax Not Included)

It's done. Latest version in p.t.s-f

Thomas


Post a reply to this message

From: Jim Holsenback
Subject: Re: A bug in shapes.inc?
Date: 18 May 2011 15:51:28
Message: <4dd42340$1@news.povray.org>
On 05/18/2011 11:51 AM, Thomas de Groot wrote:
> "Le_Forgeron"<lef### [at] freefr>  schreef in bericht
> news:4dd3d3c8$1@news.povray.org...
>
>> Silly trick: the comma is not after the vector, but before it...
>> just my 0.02? (Tax Not Included)
>
> It's done. Latest version in p.t.s-f
>
> Thomas
>
>
thanks ... nice catch ;-)
change #5436 will flow with the next release


Post a reply to this message

From: Thomas de Groot
Subject: Re: A bug in shapes.inc?
Date: 19 May 2011 03:18:47
Message: <4dd4c457$1@news.povray.org>
"Jim Holsenback" <jho### [at] povrayorg> schreef in bericht news:4dd42340> 
thanks ... nice catch ;-)
> change #5436 will flow with the next release

To make things really perfect, I just made an additional small/last 
correction. See p.t.s-f

Thomas


Post a reply to this message

<<< Previous 3 Messages Goto Initial 10 Messages

Copyright 2003-2023 Persistence of Vision Raytracer Pty. Ltd.