POV-Ray : Newsgroups : povray.beta-test : A bug in shapes.inc? : Re: A bug in shapes.inc? Server Time
25 Jun 2024 22:06:52 EDT (-0400)
  Re: A bug in shapes.inc?  
From: Jim Holsenback
Date: 18 May 2011 05:41:12
Message: <4dd39438$1@news.povray.org>
On 05/18/2011 05:17 AM, Thomas de Groot wrote:
> "Le_Forgeron"<jgr### [at] freefr>  schreef in bericht
> news:4dd2a7cf$1@news.povray.org...
>> The update should be done in the #Write of HFCreate_, to replace
>> xRes*zRes with
>> xRes,"*",zRes
>>
>> (and
>> (xRes-1)*(zRes-1)*2 with
>> (xRes-1),"*",(zRes-1),"*2"
>> ) (if you get the spirit of it ?)
>
> This is not really necessary in fact.
>
>> There already some double while-loop used to dump the vectors, so adding
>> a "\n" under #if(WriteFile) might already ease the output file.
>> (well, instead of 1 line of 1 million vectors... 1000 lines of 1000
>> vectors each... is that better ?)
>
> Better is to replace:
>          PArr[J][K],
> with:
>          #if(WriteFile)
>            PArr[J][K],"\n",
>          #else
>            PArr[J][K],
>          #end
>
> And:
>               vnormalize(vcross(PArr[J][K+1]-PArr[J][K-1],
> PArr[J+1][K]-PArr[J-1][K])),
> with:
>             #if(WriteFile)
>               vnormalize(vcross(PArr[J][K+1]-PArr[J][K-1],
> PArr[J+1][K]-PArr[J-1][K])),"\n",
>             #else
>               vnormalize(vcross(PArr[J][K+1]-PArr[J][K-1],
> PArr[J+1][K]-PArr[J-1][K])),
>             #end
>
> And:
>               <(J-1)/(xRes-1),(K-1)/(zRes-1)>,
> with:
>             #if(WriteFile)
>               <(J-1)/(xRes-1),(K-1)/(zRes-1)>,"\n",
>             #else
>               <(J-1)/(xRes-1),(K-1)/(zRes-1)>,
>             #end
>
> And finally:
>            F1+A, F2+A,
> with:
>          #if(WriteFile)
>            F1+A, F2+A,"\n",
>          #else
>            F1+A, F2+A,
>          #end
>
> This works fine.
>
> Thomas
>
>
I recently fixed warning messages that the Bevelled_Text macro (also in 
shapes.inc) was spitting out (unnecessary bounding), so when you're 
happy with the repairs you've made, attach the updated file in 
p.t.scene-files and I'll make sure it gets into the distribution.

Jim


Post a reply to this message

Copyright 2003-2023 Persistence of Vision Raytracer Pty. Ltd.