|
![](/i/fill.gif) |
Greg M. Johnson wrote:
>mercatorbase contains the macro
>...
I just had a quick look at your macro.
And below are some comments for you.
1.
Good idea.
2.
I can't understand why you use these
kind of expressions:
pow(_AnyExpression_, 1)
Is there any reason why you cannot just
write _AnyExpression_ ?
Is it to avoid some kind of bug ?
Please explain.
3.
I think that it is wise to change all
those #declare expressions within the
macro to #local expressions.
4.
Note that the p0 variable is not used
inside your macro.
5.
Have you considered shortening your
code, e.g. by replacing this part:
#declare v0 = y;
#local tr1 = transform{rotate z*_ValueB_ rotate y*_ValueA_};
#declare vul = vtransform(v0, tr1);
by something along these lines:
#declare v0 = z; // or -z
#declare vul = vrotate(v0, <_ValueC_, _ValueD_, 0>);
?
Tor Olav
Post a reply to this message
|
![](/i/fill.gif) |