|
 |
clipka <ano### [at] anonymous org> wrote:
> Am 15.06.2021 um 06:29 schrieb Ton:
>
> > So that seems to be working. What is the best way forward with the changed
> > files, ax_check_openexr.m4, povray.cpp and openexr.cpp?
>
> Thanks, much appreciated!
>
> Ideally, you'd set up a Git pull request for the `POV-Ray/povray`
> repository, based on the `release/v3.7.0` branch (NOT `master`); and if
> you feel like it, do the same based on the `release/v3.8.0` branch as
> well (again NOT `master`), but I reckon it should be easy to port the
> change over to v3.8 once it's in the Git repo.
>
> If Git is not your sort of thing, please attach the files (complete - no
> diffs please!) to a post over at `povray.binaries.programming`,
> mentioning in the post what version you took the original files from.
> Ideally someone else can take it from there and turn it into a pull
> request or two - if not, I'll probably be able to find some time to take
> it from there myself eventually.
Hallo Christoph, just created two pull requests. I hope everything on my side
was done OK, first time I've done this.
Cheers
Ton.
Post a reply to this message
|
|
|
|
Am 02.07.2021 um 02:39 schrieb Ton:
> Hallo Christoph, just created two pull requests. I hope everything on my side
> was done OK, first time I've done this.
Thanks - as for the "git technical" side, the pull requests look rock-solid.
There may be some issue with the suggested changes though - they don't
seem to build properly on Windows. I'll try to make time tomorrow to
have a closer look at what might be going on. (Also, no Unix test build
triggered for the v3.7.0 version, but that's entirely on me.)
Post a reply to this message
|
|
|
|
Am 02.07.2021 um 02:39 schrieb Ton:
> Hallo Christoph, just created two pull requests. I hope everything on my side
> was done OK, first time I've done this.
No formal complaints from my side - again, thanks!
There's one remaining issue that needs to be ironed out, and I've got a
few suggestions for additional changes that you could also throw in
along the way. See my comments to the v3.7 pull request (most also apply
to v3.8).
As for the "git-technical" side, this should be fairly straightforward:
All you'll have to do is push additional commits to the corresponding
branches of your repo copy, and the pull requests should automatically
pick those up and update themselves accordingly.
Christoph
Post a reply to this message
|
|
