On Tue, 22 Oct 2002 18:48:12 +0200, Christoph Hormann <chr### [at] gmxde>
wrote:
> > Two solutions. First, I can remove my modifications and turn off warnings -
> > but then incorporating new patches can have some warnings I could not catch.
> > Second, I can remove old behaviours and stay with new syntax when it not
> > changes features. Personally I prefer second solution but temporary I stayed
> > with #ifdefs to highlight all places modified by me.
>
> The description of your second solution seems confusing to me.  You mean
> you change the code but don't mark it with ifdef's? That would be a bad
> idea for a general patch collection.

If there could be general agreement and knowledge what is changed then I don't
think so.

> As several people pointed out the
> basis should always be the current official version.  

Then I prefer it as is.

> - 'fnintern.cpp'
>     * several helper macros at the beginning of the file
>     * f_triangle() function declaration and implementation
>     * added entry to 'POVFPU_TrapTable'
>     * changed 'POVFPU_TrapTableSize'

Seems logical.

ABX

Post a reply to this message