On 9/26/2016 5:38 AM, William F Pokorny wrote:
> Not opposed to adding the information in the tiling.pov example.
>
> I am opposed to this additional line in the example:
>
> scale TileScale
>
> which will distort what users see when exploring the tiling patterns.
>
> Perhaps make it a comment :
>
> // scale TileScale   // Unit square scale for this pattern if needed.
>
> thought I recommend deleting the line.

hmmm ... /thought/ this was the whole point of this addition

>
> Folks need to know the unit tile scale if wrapping the tiles around a
> cylinder or doing something like Jaime's wallpaper technique. Just
> setting up the switch is enough to provide the information assuming
> there is a mention in the documentation that is where the information is.
>
> I'm also a little unsure of the new additional scale up of <5,1,5>
> you've added just below. Feels large. Does it look OK with all 27 tiling
> patterns?

your addition ... didn't you test /all/ those out for yourself. that's 
why i threw this back into your court. some of the results looked 
questionable to me. as for scale <5,1,5> ... either that or move camera 
closer is all ... your code so do what you think is best

>
> Aside: There will be a similar set of 3 scalings for the pavement
> pattern, but I've just put in a pull request to add a pavement.pov
> example - so I'll go modify that pull request now instead of proposing
> wiki updates.
>
> Will you be putting in the tiling.pov pull request yourself, or would
> you like me to do it?

be my guest ...

Post a reply to this message