I was recently using the black_hole warp and noticed a 'type' option I'd 
never used. I could find no documentation on it other than the option 
being mentioned.

The code looks like it tests for and works only for type 0. My own 
testing confirms other than 0 effectively turns the black_hole warp off.

I found this from 2002: 
http://news.povray.org/povray.beta-test/thread/%3C3c44167a@news.povray.org%3E/ 
which looks like there was intent to remove the option from 3.5.

Have I missed something? Is there some current purpose for other than 
type 0?

I can imagine other black hole types - perhaps a whirlpool or oblong 
effect for example - but given the current state, should we remove the 
option and code for now as Ingo apparently planned?

If 0 is the only valid option for type at present, but others are 
planned, should we warn in the parser when it is set to something other 
than 0? Perhaps also comment the conditional in the code on type to save 
a few cyles until other options exist ?

No matter the answer(s) supposing the documentation should be updated to 
match.

Thanks for your time,
Bill P.

Post a reply to this message