POV-Ray : Newsgroups : povray.beta-test : splinefollow : Re: splinefollow Server Time
6 May 2024 01:26:50 EDT (-0400)
  Re: splinefollow  
From: Le Forgeron
Date: 27 Feb 2016 10:27:58
Message: <56d1c07e$1@news.povray.org>
Le 27/02/2016 15:58, clipka a écrit :
> Am 27.02.2016 um 15:23 schrieb Le_Forgeron:
>> If it can help, it's already in github
>>
>> https://github.com/LeForgeron/povray/commit/489e2eaf8e655eacdf102b6d5961
>> 3f0f725584b8
>>
>>> https://github.com/LeForgeron/povray/commit/489e2eaf8e655eacdf102b6d59
>> 613f0f725584b8
>>
>> But
>>
>> I do not know how to create a pull request for a single commit..
>> Just do it if you can.
> 
> Actually your solution, too, still has a bug: If the last entry of the
> spline is to be replaced, replacement is done on [i] when it should be
> on [i-1].
> 

I think that I just tried to "uncompress" the original condition (of
four tests) to avoid the problem.

And you are correct, the branch i==splineSize ... replace=true should
also reduce the value of i !

Nicely spotted.


Post a reply to this message

Copyright 2003-2023 Persistence of Vision Raytracer Pty. Ltd.