On 01/06/2015 05:42 PM, clipka wrote:
> Am 28.08.2014 um 19:41 schrieb James Holsenback:
>> On 08/20/2014 09:40 AM, clipka wrote:
>>> Am 20.08.2014 15:26, schrieb James Holsenback:
>>>
>>>> OTO_Get_Mask
>>>> <-8.00000000000000000000,-5.00000000000000000000,0.0000000000000000
>>>> 0000> Result:0.99999997764825820923
>>>>
>>>> Hmmm ... OK I think this shows problem the above is output from inside
>>>> the OTO_Get_Mask function ... I now see why reversing the logic (and my
>>>> "on a lark" test) in corner test works
>>>
>>> Bingo!
>>>
>>> Okay, you obviously have already figured a way around this problem by
>>> way of modifying OTOc.inc, and I think I now have enough information to
>>> go hunting for the root cause in the codebase.
>>>
>>> I might come back to you for testing of some code modifications, if
>>> that's ok for you.
>>>
>>
>> curious if you've had any time to follow up
>
> Now that I've returned from outer space, I have at last; can you please
> try the following patch:

Well my job (10hrs a day 7 days a week) is a black hole ...

>
> At the beginning of source/base/colour.h, around line 95, replace the
> following lines:
>
> const float kRedIntensity   = 0.297;
> const float kGreenIntensity = 0.589;
> const float kBlueIntensity  = 0.114;
>
> with this:
>
> const PreciseColourChannel kRedIntensity   = 0.297;
> const PreciseColourChannel kGreenIntensity = 0.589;
> const PreciseColourChannel kBlueIntensity  = 0.114;
>
> I /think/ it should fix the issue. The culprit would then have been
> change 0ea2da4.

I will do my best, but can't promise any sort of time frame

Post a reply to this message