Second round, on f42a95b668458bfd8bf626519669b3cdc36f0d3c

* still std::numeric_limits<> but now in base/types.h (nned <limits>)
* texture.cpp, 1266 : default shared_ptr is to nullptr, not worth setting ?
* same for normal.cpp, 593.
* base/colour.cpp:53:22: error: specializing member
‘pov_base::GenericColour<float>::mkDefaultWavelengths’ requires
‘template<>’ syntax
     const MathColour MathColour::mkDefaultWavelengths =
MathColour(RGBColour(0.70, 0.52, 0.48));

* "return GenericPigmentBlendMapPtr(NULL);" might compile better as
"return GenericPigmentBlendMapPtr()" (calling the constructor of
shared_ptr without argument, making a shared_ptr to nullptr.
(otherwise, IIRC, NULL is taken as the argument for the constructor of T
in shared_ptr<T>)

(I'm more familiar with C++11 std::shared_ptr<T>, so I might be wrong
when applied to C++03 & boost . when I need fresh instanced value,
std::make_shared<T>(params for T's constructor...) is my friend)

Thanks for your update.
-- 
IQ of crossposters with FU: 100 / (number of groups)
IQ of crossposters without FU: 100 / (1 + number of groups)
IQ of multiposters: 100 / ( (number of groups) * (number of groups))

Post a reply to this message

Attachments:
Download 'errorgcc.txt' (428 KB) Download 'erroricpc.txt' (175 KB)