Chris Cason wrote:

> I would appreciate it if some of you could sanity-check the RC4
> windows installer

Works fine on XP 32-bit, unfortunately I'm not currently
in the same country as my Windows 7 64-bit machine, I'll try
that on the weekend.

> This is a combined 32 and 64-bit setup which is the first we have done
> using NSIS (previously we used InstallShield). 

So you went down this route after all ;)

A few suggestions:

I think there should be an uninstall link (short-cut to uninstall
exe) added to the start menu. Note the uninstaller doesn't have to
reside top-level, you could also write it to $INSTDIR\bin, although
you then need to set $INSTDIR to $INSTDIR\.. on execution (even
better would be to retrieve the installdir from registry when
starting the uninstaller, then the uninstaller also works if
it gets copied to a different location).

BTW how are you removing the files? There is some dangerous sample
code floating out there that recursively removes $INSTDIR in a way that
would clear the users drive should he accidentally install to c:\.

Also note there are some optional checkboxes that could be
activated for the Finish Page, to determine whether desktop
icons should be created, some readme or manual opened, the
application automatically started after installation, ...

Finally, note there is a BgImage Plugin included with the
standard NSIS distribution. If the final version has some sort
of official raytraced image to show off the release, it could
easily be added as a fullscreen background to the installer.

Post a reply to this message