On 05-Oct-08 6:42, Chris Cason wrote:
> Slime wrote:
>>>     for (unsigned int i=0; i<c.size(); i++)
>>>       if (c[i]) out.append("1"); else out.append("0");
>> This isn't the cause of your crash, but I recommend not squishing your code 
>> together like that. Keep each statement on a separate line and use brackets 
>> around anything that's not a single simple statement:
>>
>>     for ( unsigned int i = 0; i < c.size(); i++ )
>>     {
>>         if ( c[i] )
>>             out.append( "1" );
>>         else
>>             out.append( "0" );
>>     }
> 
> If he wants brevity he could also code it like this:
> 
>   for (int i = 0; i < c.size(); i++)
>     out.append(c[i] ? "1" : "0");
> 
> which is just as valid and avoids running the if/else together.
> 
Didn't we code that more like out.append("0" + c[i]) just to confuse the 
readers?

Post a reply to this message