In article <3DB073DA.25EDB052@gmx.de> , Christoph Hormann 
<chr### [at] gmxde>  wrote:

> If this is followed thoroughly it should be very clear what code belongs
> to which patch.

Well, that makes the code harder to read when there are multiple patches,
especially when code of those patches is interleaved.  Really, MegaPOV had
that for many patches already and still later some code appeared at unusual
places that seemed to belong to patches we did not even want, either because
the #ifdefs had simply been forgotten or because one patch depended on
another and there were no #ifdefs.

That of course does not mean one should not use those #ifdefs when merging
multiple patches, but having an up-to-date patch code which only contains
the changes for that one particular patch is much easier.  In particular you
have to keep in mind that patches may not necessarily be integrated into the
exact some source code as was in the official distribution.  So the more
changes have to be tracked when merging, the more difficult it gets.
Really!


    Thorsten


____________________________________________________
Thorsten Froehlich, Duisburg, Germany
e-mail: tho### [at] trfde

Visit POV-Ray on the web: http://mac.povray.org

Post a reply to this message