ABX wrote:
> 
> Two solutions. First, I can remove my modifications and turn off warnings -
> but then incorporating new patches can have some warnings I could not catch.
> Second, I can remove old behaviours and stay with new syntax when it not
> changes features. Personally I prefer second solution but temporary I stayed
> with #ifdefs to highlight all places modified by me.

The description of your second solution seems confusing to me.  You mean
you change the code but don't mark it with ifdef's? That would be a bad
idea for a general patch collection. As several people pointed out the
basis should always be the current official version.  

IMO it would be good if every patch had a clear description of it's
purpose and a list of modified places in the source in addition to the
user documentation.  Something like:

F_TRIANGLE_PATCH

introduces a new internal function 'f_triangle'.

Modified source files:

- 'fnintern.cpp'
    * several helper macros at the beginning of the file
    * f_triangle() function declaration and implementation
    * added entry to 'POVFPU_TrapTable'
    * changed 'POVFPU_TrapTableSize'

I think this is something easy to write for the author of the patch and it
would help maintaining patch collections.

Christoph

-- 
POV-Ray tutorials, IsoWood include,                 
TransSkin and more: http://www.tu-bs.de/~y0013390/  
Last updated 13 Aug. 2002 _____./\/^>_*_<^\/\.______

Post a reply to this message