|
 |
Op 11-5-2021 om 19:44 schreef Bald Eagle:
> Thomas de Groot <tho### [at] degroot org> wrote:
>
>> I am presently looking at Bald Eagle's code with the intention to
>> implement it inside the granite macro. In that case, all declares will
>> become locals obviously and stop giving problems like you encountered.
>
> I personally might try to rename the parameters to make them unique to the
> include file. GranInc_K or something like that. 1000 times less likely that
> someone will try to use that compared to N, NN or K.
>
Done.
>> Another consequence will be that I shall need to define at least three
>> additional parameters for the granite macro: Start, End, Turbulence.
>>
>> @Bald Eagle: in your original code you also defined a parameter "Scale"
>> which subsequently was not used. Where did you want to place it? It
>> might be an interesting fourth addition.
>
> I defined that in order to scale all of the textures at once when I was
> comparing f_noise3D, StepNoise, and cells.
> If you see a place where you'd like to scale the function independently of where
> things might all be scaled together with the scale keyword, then it would get
> placed inside the N parts of the StepNoise function like: N(x/Scale).
>
Ok. I shall not use it as it appears to be redundant with other scales.
>> My reworking of the code would look like this:
>>
>> [snip]
>
> Maybe rename/preface Mod and SmoothStep.
Done.
> Also, to remove the dependency on functions.inc, f_noise3D id defined as
> function {internal(76)}.
> So maybe do: #declare GraniteNoise = function {internal(76)}
>
Hmm. Not sure yet if I want to do that. Not change for the time being.
> But I think that until you release a test version "into the wild", we won't be
> able to predict where some tricky problems may be hiding.
>
Sure.
--
Thomas
Post a reply to this message
|
|
