"Karl Anders" <kar### [at] webde> wrote:
> Hello all,
>
> I would really have loved to do this by private mail, but since SharkD doesn't
> give one ( nomail _at_ nomail ), I'll have do it publicly.
>
> First off, something positive:
> These definitions really helped me to understand the concept and usage of
> pigment_maps much better. Many thanks for the effort to you, SharkD.
>
> But there is e.g. no real yellow in your HSV/HSL-thingies.
> There are multiple color_maps like
>
> color_map
> {
>    [0 rgb <1, 0, 0>]
>    [1/3 rgb <0, 1, 0>]
>    [2/3 rgb <0, 0, 1>]
>    [1 rgb <1, 0, 0>]
> }
>
> so the best approximation to yellow is rgb<0.5,0.5,0> at 1/6.
>
> I feel that should be changed to
> color_map{
>    [ 0   rgb < 1, 0, 0 > ]
>    [ 1/6 rgb < 1, 1, 0 > ]
>    [ 2/6 rgb < 0, 1, 0 > ]
>    [ 3/6 rgb < 0, 1, 1 > ]
>    [ 4/6 rgb < 0, 0, 1 > ]
>    [ 5/6 rgb < 1, 0, 1 > ]
>    [ 1   rgb < 1, 0, 0 > ]
> }
>
> Have a nice weekend
> Karl

You are correct. I'm not sure how I missed this, as it is blaringly obvious in
the cube models. I'll fix it in the next release.

-SharkD

Post a reply to this message