 |
|
|
|
|
|
| |
| |
|
|
From: Massimo Valentini
Subject: sphere_sweep, lathe and blob optimization.
Date: 26 Dec 2002 15:21:17
Message: <3e0b64bd@news.povray.org>
|
|
|
| |
| |
|
|
I posted a simple patch to povray.binaries.programming that decreases
sensibly the rendering time of scenes with objects in subject (for
lathe and sphere_sweep when using the cubic_spline attribute).
The point is that when searching the roots of a high degree polynomial,
there's no reason to search every root in [0 Max_distance] when only
those in [0 1] are needed. I extended the function Solve_Polynomial
to accept a new parameter fixing the range of interest, and where
possible used it.
Affected files are:
src/polysolv.cpp
src/polysolv.h
src/lathe.cpp
src/blob.cpp
src/sphsweep.cpp
Scenes that show differences are, for example:
scenes/objects/lathe1c.pov
scenes/objects/lathe2.pov
scenes/objects/blob1b.pov
scenes/objects/blob1a.pov
Comments, hints appreciated as always.
Massimo
Post a reply to this message
|
|
| |
| |
|
|
From: Thorsten Froehlich
Subject: Re: sphere_sweep, lathe and blob optimization.
Date: 26 Dec 2002 16:22:53
Message: <3e0b732d@news.povray.org>
|
|
|
| |
| |
|
|
In article <3e0b64bd@news.povray.org> , "Massimo Valentini"
<six### [at] inwind it> wrote:
> Comments, hints appreciated as always.
Hi,
I saw you posted it as diff. This just makes it unnecessarily hard for
everyone to follow your changes if the diff is non-trivial as I already
explained why in the "The right way to patch POV-Ray?". I would appreciate
if you could just post the full files you changed instead...
Thorsten
____________________________________________________
Thorsten Froehlich, Duisburg, Germany
e-mail: tho### [at] trfde
Visit POV-Ray on the web: http://mac.povray.org
Post a reply to this message
|
|
| |
| |
|
|
From: Massimo Valentini
Subject: Re: sphere_sweep, lathe and blob optimization.
Date: 27 Dec 2002 04:50:54
Message: <3e0c227e$1@news.povray.org>
|
|
|
| |
| |
|
|
"Thorsten Froehlich" ha scritto
:
: > Comments, hints appreciated as always.
:
: Hi,
:
: I saw you posted it as diff. This just makes it unnecessarily hard for
: everyone to follow your changes if the diff is non-trivial as I already
: explained why in the "The right way to patch POV-Ray?". I would appreciate
: if you could just post the full files you changed instead...
:
I read your post in that thread, but I disagree.
Hard to read, it's hard because the code is unreadable.
Hard work, I don't think. Really modern, GUI based, development tools
should let you easily write macros to automate all the operations
needed to safely import a diff. Then suffices a double click on a toolbar
button.
And if you don't have such a modern tool, a simple text editor is
sufficient to inspect all the changes.
And regarding the few Kb, it's a courtesy for those not having
a fast internet connection, but that could give you a feedback.
Anyway I posted a zipped tar of the files affected.
Massimo
Post a reply to this message
|
|
| |
| |
|
|
From: Thorsten Froehlich
Subject: Re: sphere_sweep, lathe and blob optimization.
Date: 27 Dec 2002 05:25:52
Message: <3e0c2ab0$1@news.povray.org>
|
|
|
| |
| |
|
|
In article <3e0c227e$1@news.povray.org> , "Massimo Valentini"
<six### [at] inwindit> wrote:
> Hard work, I don't think. Really modern, GUI based, development tools
> should let you easily write macros to automate all the operations
> needed to safely import a diff. Then suffices a double click on a toolbar
> button.
Well, the importing into unchanged source code isn't a problem. But I
rarely have an _active_ plain 3.50 source tree somewhere. Plus I need to
see what changes are made because in the end, when I commit them, I am the
one going to be responsible if they break POV-Ray...
> Anyway I posted a zipped tar of the files affected.
Thank you very much!!!
Thorsten
____________________________________________________
Thorsten Froehlich, Duisburg, Germany
e-mail: tho### [at] trfde
Visit POV-Ray on the web: http://mac.povray.org
Post a reply to this message
|
|
| |
| |
|
|
|
|
| |
|
|
