 |
|
|
|
|
|
| |
| |
|
|
|
|
| |
| |
|
|
In an earlier message, Nathan Kopp said that NO_GLOBAL_LIGHTS_SET_FLAG in
objects.h is unused and should be removed. However, it is used in one piece
of code, around line 2858 of parse.cpp (at the end of Parse_Light_Group):
Set_CSG_Children_Flag((OBJECT *)Object, Test_Flag((OBJECT *)Object,
NO_GLOBAL_LIGHTS_FLAG),
NO_GLOBAL_LIGHTS_FLAG, NO_GLOBAL_LIGHTS_SET_FLAG);
There is no other code that uses NO_GLOBAL_LIGHTS_SET_FLAG, so I suspect
this is a bug.
--
light_source{6#local D=#macro B(E)#macro A(D)#declare E=(E-#declare
C=mod(E D);C)/D;C#end#while(E)#if(A(8)=7)#declare D=D+2.8;#else#if(
C>2)}torus{1..2clipped_by{box{-2y}}rotate<1 0C>*90translate<D+1A(2)
*2+1#else}cylinder{0(C-v=1).2translate<D+C*A(2)A(4)#end-2 13>finish
{specular 1}pigment{rgb x}#end#end#end-8;1B(445000298)B(519053970)B
(483402386)B(1445571258)B(77778740)B(541684549)B(42677491)B(70)}
Post a reply to this message
|
|
| |
| |
|
|
|
|
| |
| |
|
|
In article <3de459e4$1@news.povray.org> , "Anders K." <and### [at] kaseorg com>
wrote:
> There is no other code that uses NO_GLOBAL_LIGHTS_SET_FLAG, so I suspect
> this is a bug.
In what way would this be a bug? A flag is set that isn't used later on.
Thorsten
____________________________________________________
Thorsten Froehlich, Duisburg, Germany
e-mail: tho### [at] trfde
Visit POV-Ray on the web: http://mac.povray.org
Post a reply to this message
|
|
| |
| |
|
|
|
|
| |
| |
|
|
I wrote:
> > There is no other code that uses NO_GLOBAL_LIGHTS_SET_FLAG, so I suspect
> > this is a bug.
Thorsten Froehlich wrote:
> In what way would this be a bug? A flag is set that isn't used later on.
Actually, if I understand the code right, NO_GLOBAL_LIGHTS_FLAG is being
changed in Object's children to match Object if the child has
NO_GLOBAL_LIGHTS_SET_FLAG on. But as Slime mentioned in the earlier thread,
NO_GLOBAL_LIGHTS_SET_FLAG has the same value as PH_TARGET_FLAG, which may
lead to problems.
Is the proper fix to remove the line I metioned, or does something else need
to be done?
Anders
Post a reply to this message
|
|
| |
| |
|
|
|
|
| |
| |
|
|
In article <3de4f9c0$1@news.povray.org> , "Anders K." <and### [at] kaseorgcom>
wrote:
> Is the proper fix to remove the line I metioned, or does something else need
> to be done?
You can just remove it, yes.
Thorsten
____________________________________________________
Thorsten Froehlich, Duisburg, Germany
e-mail: tho### [at] trfde
Visit POV-Ray on the web: http://mac.povray.org
Post a reply to this message
|
|
| |
| |
|
|
|
|
| |
|
|
