Since no-one seems to be reading p.b.p, I'll repost here:
It seems that the way most people upload their patches to p.b.p is using
diff.  I've never used diff before, but I see that it can produce a number
of different output formats - which should I use?  Is there anything else I
should know about using diff or releasing patches?
Also, what are the conventions for filling in the 'Modified:' fields in the
source? - i.e. Do I make notes in tokenize.c, frame.h, parse.h, interior.c
and parstxtr.c, where very small additions have been made?  Do I make notes
in lighting.c where the modifications to actual calculations have been made?

Post a reply to this message

"Edward C." wrote:

> Since no-one seems to be reading p.b.p, I'll repost here:
> It seems that the way most people upload their patches to p.b.p is using
> diff.  I've never used diff before, but I see that it can produce a number
> of different output formats - which should I use?  Is there anything else I
> should know about using diff or releasing patches?
> Also, what are the conventions for filling in the 'Modified:' fields in the
> source? - i.e. Do I make notes in tokenize.c, frame.h, parse.h, interior.c
> and parstxtr.c, where very small additions have been made?  Do I make notes
> in lighting.c where the modifications to actual calculations have been made?

Hmmm. Not sure.
I'm in the same boat as you.

Any help out here, people?  :-)

Hopefully, I'll figure out soon.

--
"My new computer's got the clocks, it rocks
But it was obsolete before I opened the box" - W.A.Y.

Post a reply to this message

In article <37D362AD.2ACC72DC@geocities.com> , "Jon A. Cruz" 
<jon### [at] geocitiescom> wrote:
> "Edward C." wrote:
>
>> Since no-one seems to be reading p.b.p, I'll repost here:
>> It seems that the way most people upload their patches to p.b.p is using
>> diff.  I've never used diff before, but I see that it can produce a number
>> of different output formats - which should I use?  Is there anything else I
>> should know about using diff or releasing patches?
>> Also, what are the conventions for filling in the 'Modified:' fields in the
>> source? - i.e. Do I make notes in tokenize.c, frame.h, parse.h, interior.c
>> and parstxtr.c, where very small additions have been made?  Do I make notes
>> in lighting.c where the modifications to actual calculations have been made?
>
> Hmmm. Not sure.
> I'm in the same boat as you.
>
> Any help out here, people?  :-)
>
> Hopefully, I'll figure out soon.

So far I have used:

diff -r -c SOURCE.OLD SOURCE.NEW >POV31A1E.PAT


As for the source code, povlegal.doc says to make clear is is a custom
version. You will surely have to fill out the distribution message in
optout.h:

#define DISTRIBUTION_MESSAGE_1 "This is an unofficial version compiled by:"
#define DISTRIBUTION_MESSAGE_2 "FILL IN NAME HERE........................."
#define DISTRIBUTION_MESSAGE_3 "The POV-Ray Team(tm) is not responsible for
supporting this version."

I have seen patches that add to every header in every source file that the
source is for an unofficial version. With that you are likely on the safe
side.
If you are not sure what is needed, I would suggest contacting the team
coordinator using the pov### [at] povrayorg e-mail address and ask for a
clarification.


     Thorsten


____________________________________________________
Thorsten Froehlich, Duisburg, Germany

Post a reply to this message