On 15.12.10 21:06, xoros wrote:
> Hello,
>
> I would like to build povray 3.7 beta40 on mac osx snow leopard, but it doesn't
> work.
> "./configure" works without any problems, but "make" always produces the
> following error:
>
> .../../source/backend/support/task.h:184: error: thread-local storage not
> supported for this target

This is not surprising as Apple boycotts the GPL3 versions of gcc, which 
effectively means all recent versions of gcc. What you need to do is select 
the llvm compiler that comes with the latest XCode rather than use the 
default gcc.

     Thorsten

Post a reply to this message

Thorsten Froehlich <tho### [at] trfde> wrote:
> On 15.12.10 21:06, xoros wrote:
> > Hello,
> >
> > I would like to build povray 3.7 beta40 on mac osx snow leopard, but it doesn't
> > work.
> > "./configure" works without any problems, but "make" always produces the
> > following error:
> >
> > .../../source/backend/support/task.h:184: error: thread-local storage not
> > supported for this target

I ran into this too.

> This is not surprising as Apple boycotts the GPL3 versions of gcc, which
> effectively means all recent versions of gcc. What you need to do is select
> the llvm compiler that comes with the latest XCode rather than use the
> default gcc.

Could you just refactor the POV code to use boost's thread local storage
instead? Obviously more than just one person would find that helpful.

Cheers,
Edouard.

Post a reply to this message

On 12/16/2010 05:17 PM, Edouard wrote:
> Thorsten Froehlich <tho### [at] trfde> wrote:
>> On 15.12.10 21:06, xoros wrote:
>>> Hello,
>>>
>>> I would like to build povray 3.7 beta40 on mac osx snow leopard, but it doesn't
>>> work.
>>> "./configure" works without any problems, but "make" always produces the
>>> following error:
>>>
>>> .../../source/backend/support/task.h:184: error: thread-local storage not
>>> supported for this target
> 
> I ran into this too.
> 
>> This is not surprising as Apple boycotts the GPL3 versions of gcc, which
>> effectively means all recent versions of gcc. What you need to do is select
>> the llvm compiler that comes with the latest XCode rather than use the
>> default gcc.
> 
> Could you just refactor the POV code to use boost's thread local storage
> instead? Obviously more than just one person would find that helpful.
> 
> Cheers,
> Edouard.
> 
> 
haha ... just press the "easy button" and poof she's done ... not hardly

Post a reply to this message

On 16.12.10 22:17, Edouard wrote:
> Could you just refactor the POV code to use boost's thread local storage
> instead? Obviously more than just one person would find that helpful.

No, because we won't need that code at all and it will go away in 3.71. It 
was actually changed from boost code to this at a time when I had little 
time to take care of the Mac side, hence it was not noticed early on that it 
is a problem.

	Thorsten

Post a reply to this message

Thorsten Froehlich <tho### [at] trfde> wrote:
> On 16.12.10 22:17, Edouard wrote:
> > Could you just refactor the POV code to use boost's thread local storage
> > instead? Obviously more than just one person would find that helpful.
>
> No, because we won't need that code at all and it will go away in 3.71. It
> was actually changed from boost code to this at a time when I had little
> time to take care of the Mac side, hence it was not noticed early on that it
> is a problem.

Doesn't really help the Mac users now though. Unless you're going to release
some 3.71 alpha source in the next few days. That would be great.

>  Thorsten

Cheers,
Edouard.

Post a reply to this message

On 18.12.10 10:00, Edouard wrote:
> Thorsten Froehlich<tho### [at] trfde>  wrote:
>> On 16.12.10 22:17, Edouard wrote:
>>> Could you just refactor the POV code to use boost's thread local storage
>>> instead? Obviously more than just one person would find that helpful.
>>
>> No, because we won't need that code at all and it will go away in 3.71. It
>> was actually changed from boost code to this at a time when I had little
>> time to take care of the Mac side, hence it was not noticed early on that it
>> is a problem.
>
> Doesn't really help the Mac users now though. Unless you're going to release
> some 3.71 alpha source in the next few days. That would be great.

Well, this is not new at all. It has been in the code for well over a year. 
So expecting a release of new source code in a few days for seems rather 
strange...

	Thorsten

Post a reply to this message

"xoros" <xor### [at] fakehostcom> wrote:
> Hello,
>
> I would like to build povray 3.7 beta40 on mac osx snow leopard, but it doesn't
> work.
> "./configure" works without any problems, but "make" always produces the
> following error:
>
> .../../source/backend/support/task.h:184: error: thread-local storage not
> supported for this target
>
> MacMegaPov isn't an option for me, because I need a command line version of
> povray.
>
> Best regards

The patch below will make povray 3.7 beta40 compile fine on max osx.
Unfortunately, I'm not allowed to post attachements to this newsgroup so I also
put it here: http://pastebin.com/TYugP76L .

The idea is to use the thread local storage API defined by POSIX. It's not as
convenient as gcc's __thread but it is portable on POSIX platforms.

The last part of the patch brings the type uint alive by including sys/types.h.


diff -uwr original/povray-3.7.0.beta.40/source/backend/frame.h
new/povray-3.7.0.beta.40/source/backend/frame.h
--- original/povray-3.7.0.beta.40/source/backend/frame.h 2010-12-06
12:55:33.000000000 +0100
+++ new/povray-3.7.0.beta.40/source/backend/frame.h 2010-12-21
22:59:33.000000000 +0100
@@ -96,6 +96,9 @@

 // Generic header for all modules

+#include <pthread.h>
+
+
 #include <new>

 #include <stdio.h>
@@ -1898,9 +1901,55 @@
 // you'll need to fix your platform-specific config to provide a means to
declare
 // thread-local variables. support for TLS is required for efficient access by
the
 // render threads to their stats and cache data.
+
+
 #ifndef DECLARE_THREAD_LOCAL_PTR
+#ifdef __APPLE__
+template<typename T>
+class Pthread_Thread_Local_Storage
+{
+ public:
+ Pthread_Thread_Local_Storage()
+  {
+    pthread_key_create(&m_key, NULL);
+  }
+
+ Pthread_Thread_Local_Storage(T *ptr)
+  {
+    pthread_key_create(&m_key, NULL);
+    pthread_setspecific(m_key, ptr);
+  }
+ //  ~Pthread_Thread_Local_Storage() {};
+
+  Pthread_Thread_Local_Storage& operator=(T const &rhs)
+  {
+    pthread_setspecific(m_key, rhs);
+    return *this;
+  };
+
+  bool operator!=(T* rhs)
+  {
+    return pthread_getspecific(m_key) != rhs;
+  }
+
+  T* operator->() const
+  {
+    return static_cast<T*>(pthread_getspecific(m_key));
+  }
+
+  operator T*() const
+  {
+    return static_cast<T*>(pthread_getspecific(m_key));
+  }
+
+ private:
+  pthread_key_t m_key;
+};
+#  define DECLARE_THREAD_LOCAL_PTR(ptrType, ptrName)
Pthread_Thread_Local_Storage<ptrType> ptrName;
+#else
 #define DECLARE_THREAD_LOCAL_PTR(ptrType, ptrName)       __thread ptrType
*ptrName;
 #endif
+#endif

 }

diff -uwr original/povray-3.7.0.beta.40/vfe/vfesession.h
new/povray-3.7.0.beta.40/vfe/vfesession.h
--- original/povray-3.7.0.beta.40/vfe/vfesession.h 2010-12-06 12:55:33.000000000
+0100
+++ new/povray-3.7.0.beta.40/vfe/vfesession.h 2010-12-21 22:36:54.000000000
+0100
@@ -94,6 +94,8 @@
 #ifndef __VFESESSION_H__
 #define __VFESESSION_H__

+#include <sys/types.h>
+
 #include <queue>

 namespace vfe

Post a reply to this message

"jonas.bulow" <jon### [at] gmailcom> wrote:
> "xoros" <xor### [at] fakehostcom> wrote:
> > Hello,
> >
> > I would like to build povray 3.7 beta40 on mac osx snow leopard, but it doesn't
> > work.
> > "./configure" works without any problems, but "make" always produces the
> > following error:
> >
> > .../../source/backend/support/task.h:184: error: thread-local storage not
> > supported for this target
> >
> > MacMegaPov isn't an option for me, because I need a command line version of
> > povray.
> >
> > Best regards
>
> The patch below will make povray 3.7 beta40 compile fine on max osx.
> Unfortunately, I'm not allowed to post attachements to this newsgroup so I also
> put it here: http://pastebin.com/TYugP76L .
>
> The idea is to use the thread local storage API defined by POSIX. It's not as
> convenient as gcc's __thread but it is portable on POSIX platforms.
>
> The last part of the patch brings the type uint alive by including sys/types.h.
>


I'm trying to compile RC2 and have the same error as the original poster.  This
patch doesn't seem to be able to be automatically applied to frame.h in RC2, and
I wasn't able to figure out what the changes need to be.  This patch does work
great for me on beta40; I checked today and was able to compile with no
problems.  In frame.h, what in beta40 we had:

#define DECLARE_THREAD_LOCAL_PTR(ptrType, ptrName)
Pthread_Thread_Local_Pointer<ptrType> ptrName;
#else
#efine DECLARE_THREAD_LOCAL_PTR(ptrType, ptrName)       __thread ptrType
*ptrName;
#endif

but in RC2 we now have:

#ifndef DECLARE_THREAD_LOCAL_PTR
#define DECLARE_THREAD_LOCAL_PTR(ptrType, ptrName)
boost::thread_specific_ptr<ptrType> ptrName
#define IMPLEMENT_THREAD_LOCAL_PTR(ptrType, ptrName, ptrCleanup)
boost::thread_specific_ptr<ptrType> ptrName(ptrCleanup)
#define GET_THREAD_LOCAL_PTR(ptrName)
(ptrName.get())
#define SET_THREAD_LOCAL_PTR(ptrName, ptrValue)
(ptrName.reset(ptrValue))
#endif

I'm not knowledgable enough to know how to modify the patch for RC2.  Can
someone help?  I'm trying to compile on Mac OS X 10.6.6 using the llvm-gcc
compiler.

Thanks for any help you can provide,

Adam

Post a reply to this message

"Adam Weyhaupt" <ada### [at] gmailcom> wrote:

> [...]
> I'm trying to compile RC2 and have the same error as the original poster.  This
> patch doesn't seem to be able to be automatically applied to frame.h in RC2, and
> I wasn't able to figure out what the changes need to be.  This patch does work
> great for me on beta40; I checked today and was able to compile with no
> problems.  In frame.h, what in beta40 we had:

I've just compiled RC3 on Mac OS X 10.6.7. You have to make following changes:

in vfe/unix/syspovconfig.h remove lines 174-177 (#defines regarding
THREAD_LOCAL_PTR)
in vfe/unix/vfeplatform.h add #include <sys/types.h> before #include
<boost/shared_ptr.hpp>
in vfe/vfesession.h add #include <sys/types.h> before #include <queue>
in source/base/image/image.cpp replace all occurrences of lseek64 with lseek


--
Greetings,

Szczepan Kuzniarz

Post a reply to this message

"Szczepan Kuzniarz" <szc### [at] gmailcom> wrote:
> "Adam Weyhaupt" <ada### [at] gmailcom> wrote:
>
> > [...]
> > I'm trying to compile RC2 and have the same error as the original poster.  This
> > patch doesn't seem to be able to be automatically applied to frame.h in RC2, and
> > I wasn't able to figure out what the changes need to be.  This patch does work
> > great for me on beta40; I checked today and was able to compile with no
> > problems.  In frame.h, what in beta40 we had:
>
> I've just compiled RC3 on Mac OS X 10.6.7. You have to make following changes:
>
> in vfe/unix/syspovconfig.h remove lines 174-177 (#defines regarding
> THREAD_LOCAL_PTR)
> in vfe/unix/vfeplatform.h add #include <sys/types.h> before #include
> <boost/shared_ptr.hpp>
> in vfe/vfesession.h add #include <sys/types.h> before #include <queue>
> in source/base/image/image.cpp replace all occurrences of lseek64 with lseek
>
>
> --
> Greetings,
>
> Szczepan Kuzniarz

GREAT!!!! Thanks!!!!!

Post a reply to this message