POV-Ray : Newsgroups : povray.beta-test : Results after recent clang cleanup commits changed. Server Time: 22 Sep 2018 06:56:55 GMT
  Results after recent clang cleanup commits changed. (Message 1 to 4 of 4)  
From: William F Pokorny
Subject: Results after recent clang cleanup commits changed.
Date: 8 Sep 2018 13:54:47
Message: <5b93d4a7$1@news.povray.org>
Christoph,

Recent commits have broken something. I'd bet on the trouble being with 
the first clang clean up one.

On the left an image from commit 851a509 Tue May 22 19:00:44 2018 +0200.

In the middle the current master at commit 264fa22 Fri Sep 7 16:52:19 
2018 +0200.

On the right the difference.

Ubuntu 18.04.  g++ 7.3.0.

Bill P.


Post a reply to this message


Attachments:
Download 'z1_to_z2.png' (63 KB)
Download 'z.pov.txt' (2 KB)

Preview of image 'z1_to_z2.png'
z1_to_z2.png


 

From: clipka
Subject: Re: Results after recent clang cleanup commits changed.
Date: 9 Sep 2018 14:43:18
Message: <5b953186$1@news.povray.org>
Am 08.09.2018 um 15:54 schrieb William F Pokorny:
> Christoph,
> 
> Recent commits have broken something. I'd bet on the trouble being with
> the first clang clean up one.
> 
> On the left an image from commit 851a509 Tue May 22 19:00:44 2018 +0200.
> 
> In the middle the current master at commit 264fa22 Fri Sep 7 16:52:19
> 2018 +0200.

The posted scene can't possibly be the one used to render the images
(*), so there may be something else going on you didn't consider.

(*The version number displayed by the posted scene will always be `3.70`
regardless of the POV-Ray version used. Also, I'm getting an even
slightly brighter image with the v3.8-alpha I've used for the first test.)

I'll continue to investigate though.


Post a reply to this message

From: clipka
Subject: Re: Results after recent clang cleanup commits changed.
Date: 9 Sep 2018 15:34:50
Message: <5b953d9a$1@news.povray.org>
Am 08.09.2018 um 15:54 schrieb William F Pokorny:
> Recent commits have broken something. I'd bet on the trouble being with
> the first clang clean up one.

Got it.

Stupid error, actually. Leading to -- guess what -- a gamma problem.

If image brightness appears to be changing, always suspect gamma.


Post a reply to this message

From: William F Pokorny
Subject: Re: Results after recent clang cleanup commits changed.
Date: 10 Sep 2018 12:47:08
Message: <5b9667cc$1@news.povray.org>
On 09/09/2018 11:34 AM, clipka wrote:
> Am 08.09.2018 um 15:54 schrieb William F Pokorny:
>> Recent commits have broken something. I'd bet on the trouble being with
>> the first clang clean up one.
> 
> Got it.
> 
> Stupid error, actually. Leading to -- guess what -- a gamma problem.
> 
> If image brightness appears to be changing, always suspect gamma.
> 
Good. Thanks. Yes, I changed #version to 3.7 as a quick 
after-thought-test and forgot to change it back before attaching it...

Bill P.


Post a reply to this message

Copyright 2003-2008 Persistence of Vision Raytracer Pty. Ltd.