POV-Ray : Newsgroups : povray.beta-test : New black_hole type of 1 proposed as github pull request #86. : Re: New black_hole type of 1 proposed as github pull request #86. Server Time
25 Apr 2024 19:20:47 EDT (-0400)
  Re: New black_hole type of 1 proposed as github pull request #86.  
From: William F Pokorny
Date: 1 Oct 2016 05:59:24
Message: <57ef88fc$1@news.povray.org>
On 09/30/2016 03:33 PM, clipka wrote:
> Am 10.09.2016 um 14:47 schrieb William F Pokorny:
>
>>>> Original github checks clean, but fail after manually bumping up the
>>>> version numbers in the branch. Unsure why.
>>>
>>> It conflicts with changes made to the master branch after you branched
>>> off (the version numbers, evidently).
>>>
>>> I must confess that version number handling is something that seriously
>>> bothers me, with a good solution still waiting to be found.
>
> FYI, I've just ditched the running version number from the master
> branch, as it turns out to really come crashing down with any reasonable
> number of open pull requests around. Once you strip any trailing numbers
> after the "alpha" from your pending pull requests, things should run a
> good deal more smoothly from now on. (The pre-commit hook should be fine
> with this new mode of operation, though it becomes less relevant anyway.)
>
> I've instead added an advice to README.md to not build from the master
> branch, but from tagged version only. Tagged versions will continue to
> have trailing numbers after the "alpha" so that they can be uniquely
> identified for the sake of providing support, but they will be managed
> in a dedicated branch, to be updated from time to time from the master
> branch.
>
OK. Thanks. I'll update my remaining pull requests to this new approach. 


Bill P.


Post a reply to this message

Copyright 2003-2023 Persistence of Vision Raytracer Pty. Ltd.